Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 382433003: Remove all-passing expectation for testharness.js-based test (Closed)

Created:
6 years, 5 months ago by jsbell
Modified:
6 years, 5 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Remove all-passing expectation for testharness.js-based test This useless -expected.txt file must have slipped in between r176164 (which removed all such expected files) and the follow-up PRESUBMIT to prevent them from being added. TBR=mlamouri@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178012

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
D LayoutTests/fast/encoding/api/utf16-surrogates-encode-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 5 months ago (2014-07-11 23:27:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/382433003/1
6 years, 5 months ago (2014-07-11 23:28:07 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-12 00:40:29 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-12 01:10:52 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/23387)
6 years, 5 months ago (2014-07-12 01:10:53 UTC) #5
mlamouri (slow - plz ping)
lgtm
6 years, 5 months ago (2014-07-13 14:42:42 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-13 15:02:50 UTC) #7
Message was sent while issue was closed.
Change committed as 178012

Powered by Google App Engine
This is Rietveld 408576698