tools/telemetry/run_tests - Issue 382433002: [telemetry] OutputFormatter for unit tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/telemetry/run_tests

Issue 382433002: [telemetry] OutputFormatter for unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « tools/perf/run_tests ('k') | tools/telemetry/telemetry/unittest/gtest_output_formatter.py » ('j') | tools/telemetry/telemetry/unittest/gtest_output_formatter.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 #!/usr/bin/env python	1 #!/usr/bin/env python

2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

3 # Use of this source code is governed by a BSD-style license that can be	3 # Use of this source code is governed by a BSD-style license that can be

4 # found in the LICENSE file.	4 # found in the LICENSE file.

5	5

6 import os	6 import os

7 import sys	7 import sys

8	8

	9 from telemetry.unittest import gtest_output_formatter

9 from telemetry.unittest import run_tests	10 from telemetry.unittest import run_tests

10	11

11	12

12 if __name__ == '__main__':	13 if __name__ == '__main__':

13 base_dir = os.path.dirname(os.path.realpath(__file__))	14 base_dir = os.path.dirname(os.path.realpath(__file__))

14 run_tests.environment = run_tests.Environment(base_dir, [base_dir])	15 output_formatters = [

	16 gtest_output_formatter.GTestOutputFormatter(sys.stdout)]

	17 run_tests.environment = run_tests.Environment(

	18 base_dir, [base_dir], output_formatters)
	nednguyen 2014/07/09 17:26:46 It seems weird for output_formatters to be part of It seems weird for output_formatters to be part of run_test.environment. What about "run_test.output_formatters = ..." instead? dtu 2014/07/10 00:35:01 I don't think it's weird. Different callers are go Show quoted text On 2014/07/09 17:26:46, nednguyen wrote: > It seems weird for output_formatters to be part of run_test.environment. What > about "run_test.output_formatters = ..." instead? I don't think it's weird. Different callers are going to want output in different formats, and environment is there to provide customization at this level. E.g. ChromeOS won't switch to JSON at the same time as chromium.perf. We'd like to have fewer globals - it's on my plate to move environment into a variable that's passed to main().
15 sys.exit(run_tests.RunTestsCommand.main())	19 sys.exit(run_tests.RunTestsCommand.main())

OLD	NEW