Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 382423002: remove WebMediaPlayerAndroid::exitFullscreen() call (Closed)

Created:
6 years, 5 months ago by qinmin
Modified:
6 years, 5 months ago
Reviewers:
trchen
CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

remove WebMediaPlayerAndroid::exitFullscreen() call This call is no longer called by FullscreenController, blink change https://codereview.chromium.org/385943005/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/renderer/media/android/webmediaplayer_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
qinmin
PTAL
6 years, 5 months ago (2014-07-12 00:16:59 UTC) #1
trchen
On 2014/07/12 00:16:59, qinmin wrote: > PTAL lgtm
6 years, 5 months ago (2014-07-12 00:27:58 UTC) #2
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 5 months ago (2014-07-12 00:38:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/382423002/1
6 years, 5 months ago (2014-07-12 00:40:02 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 06:21:41 UTC) #5
Message was sent while issue was closed.
Change committed as 282809

Powered by Google App Engine
This is Rietveld 408576698