Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Unified Diff: ipc/ipc_channel_proxy.h

Issue 382333002: Introduce ChannelMojo (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ipc/ipc_channel_proxy.h
diff --git a/ipc/ipc_channel_proxy.h b/ipc/ipc_channel_proxy.h
index 2e483acbf4d60170933a053b796e2c35e8fc0fba..b810b76cc3c0dbdb7e59f9fcc972539bafef5e33 100644
--- a/ipc/ipc_channel_proxy.h
+++ b/ipc/ipc_channel_proxy.h
@@ -22,6 +22,7 @@ class SingleThreadTaskRunner;
namespace IPC {
+class ChannelBuilder;
class MessageFilter;
class MessageFilterRouter;
class SendCallbackHelper;
@@ -70,6 +71,11 @@ class IPC_EXPORT ChannelProxy : public Sender, public base::NonThreadSafe {
Listener* listener,
base::SingleThreadTaskRunner* ipc_task_runner);
+ static scoped_ptr<ChannelProxy> Create(
+ scoped_ptr<ChannelBuilder> builder,
darin (slow to review) 2014/07/15 23:32:49 ChannelFactory definitely feels like the better na
+ Listener* listener,
+ base::SingleThreadTaskRunner* ipc_task_runner);
+
virtual ~ChannelProxy();
// Initializes the channel proxy. Only call this once to initialize a channel
@@ -78,6 +84,7 @@ class IPC_EXPORT ChannelProxy : public Sender, public base::NonThreadSafe {
// thread.
void Init(const IPC::ChannelHandle& channel_handle, Channel::Mode mode,
bool create_pipe_now);
+ void Init(scoped_ptr<ChannelBuilder> builder, bool create_pipe_now);
// Close the IPC::Channel. This operation completes asynchronously, once the
// background thread processes the command to close the channel. It is ok to
@@ -171,8 +178,7 @@ class IPC_EXPORT ChannelProxy : public Sender, public base::NonThreadSafe {
friend class SendCallbackHelper;
// Create the Channel
- void CreateChannel(const IPC::ChannelHandle& channel_handle,
- const Channel::Mode& mode);
+ void CreateChannel(scoped_ptr<ChannelBuilder> builder);
// Methods called on the IO thread.
void OnSendMessage(scoped_ptr<Message> message_ptr);

Powered by Google App Engine
This is Rietveld 408576698