Introduce ChannelMojo

ipc/ipc_channel_builder.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.

[viettrungluu, 2014/07/15 16:28:07]

2014, etc. (and everywhere else)

[Hajime Morrita, 2014/07/15 18:46:17]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ipc/ipc_channel_builder.h"
+
+namespace IPC {
+
+namespace {
+
+class PlatformChannelBuilder : public ChannelBuilder {
+ public:
+  PlatformChannelBuilder(ChannelHandle handle,
+                         Channel::Mode mode)
+      : handle_(handle), mode_(mode) {
+  }
+
+  virtual std::string GetName() const OVERRIDE {
+    return handle_.name;
+  }
+
+  virtual scoped_ptr<Channel> BuildChannel(
+      Listener* listener) OVERRIDE {
+    return Channel::Create(handle_, mode_, listener);
+  }
+
+ private:
+  ChannelHandle handle_;
+  Channel::Mode mode_;
+};

[viettrungluu, 2014/07/15 16:28:06]

Probably you should have a DISALLOW_COPY_AND_ASSIGN here, for good form.

[Hajime Morrita, 2014/07/15 18:46:17]

Done.

+
+}

[viettrungluu, 2014/07/15 16:28:06]

nit: A "// namespace" comment would be nice

[Hajime Morrita, 2014/07/15 18:46:17]

Done.

+
+// static
+scoped_ptr<ChannelBuilder> ChannelBuilder::CreatePlatformBuilder(
+    const ChannelHandle& handle, Channel::Mode mode) {
+  return make_scoped_ptr(new PlatformChannelBuilder(

[viettrungluu, 2014/07/15 16:28:07]

nit: I think you can just do scoped_ptr<ChannelBuilder>(new ...);, which is
shorter than make_scoped_ptr + PassAs.

[Hajime Morrita, 2014/07/15 18:46:17]

Right. Done.

+      handle, mode)).PassAs<ChannelBuilder>();
+}
+
+}  // namespace IPC