components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc - Issue 382313003: Add data reduction functionality to all platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc

Issue 382313003: Add data reduction functionality to all platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed all comments by mmenke. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc

diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc b/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc

index bdbb9bfc76ceee209018df4ea9d0db25474ced29..fea0077ccb0276e3ddb9aeba57251ed190ee43af 100644

--- a/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc

+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc

@@ -74,7 +74,7 @@ void DataReductionProxyUsageStats::RecordDataReductionProxyBypassInfo(

DataReductionProxyUsageStats::DataReductionProxyUsageStats(

DataReductionProxyParams* params,

- MessageLoopProxy* ui_thread_proxy)

+ scoped_refptr<MessageLoopProxy> ui_thread_proxy)

Not at Google. Contact bengr 2014/09/05 21:24:35 FYI, I had to make this change to get it to build

Ryan Sleevi 2014/09/05 21:28:31 This should be a const-ref. The only pass by value

Not at Google. Contact bengr 2014/09/05 22:08:58 Done. For my own edification, can you please expla

: data_reduction_proxy_params_(params),

last_bypass_type_(BYPASS_EVENT_TYPE_MAX),

triggering_request_(true),

« no previous file with comments | « components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h ('k') | net/http/http_log_util.cc » ('j') | no next file with comments »