Add data reduction functionality to all platforms.

net/http/http_log_util.cc

Index: net/http/http_log_util.cc
diff --git a/net/http/http_log_util.cc b/net/http/http_log_util.cc
index 570232fc3e75be5e049372094825c68b7de51bce..603eef4beab6c97417f1db1ef93bba3c0fbae238 100644
--- a/net/http/http_log_util.cc
+++ b/net/http/http_log_util.cc
@@ -34,7 +34,6 @@ bool ShouldRedactChallenge(HttpAuthChallengeTokenizer* challenge) {
 
 }  // namespace
 
-#if defined(SPDY_PROXY_AUTH_ORIGIN)
 void ElideChromeProxyDirective(const std::string& header_value,

[Ryan Sleevi, 2014/07/22 01:56:31]

Absolutely cannot support moving this out of the #ifdef.

[Ryan Sleevi, 2014/07/22 08:22:25]

This is one aspect we've talked about in the past. Eliding such proxy directives
does not belong in //net. The naming alone is a dead give-away.

Redacting such data - including from information like NetLog - really does not
belong in //net.

[bengr, 2014/07/22 19:57:15]

mmenke@ was the reviewer on this CL (see:
https://codereview.chromium.org/361053002/) and we discussed offline the
possibility of wrapping the NetLog to include such logic, but his opinion (and
mine) was that it wasn't worth the effort.

                                const std::string& directive,
                                std::string::const_iterator* redact_begin,
@@ -50,18 +49,15 @@ void ElideChromeProxyDirective(const std::string& header_value,
     }
   }
 }
-#endif
 
 std::string ElideHeaderValueForNetLog(NetLog::LogLevel log_level,
                                       const std::string& header,
                                       const std::string& value) {
   std::string::const_iterator redact_begin = value.begin();
   std::string::const_iterator redact_end = value.begin();
-#if defined(SPDY_PROXY_AUTH_ORIGIN)
   if (!base::strcasecmp(header.c_str(), "chrome-proxy")) {

[Ryan Sleevi, 2014/07/22 01:56:31]

Nor this.

[Ryan Sleevi, 2014/07/22 08:22:25]

1) //net knowing about chrome-proxy
2) Introducing chrome-proxy as a header
3) Whitewashing the NetLog from //net based on embedder needs.

[bengr, 2014/07/22 19:57:15]

We can file a bug to wrap NetLog, but this shouldn't block this CL.

     ElideChromeProxyDirective(value, "sid=", &redact_begin, &redact_end);
   }
-#endif
 
   if (redact_begin == redact_end &&
       log_level >= NetLog::LOG_STRIP_PRIVATE_DATA) {