Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_params.h

Issue 382313003: Add data reduction functionality to all platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove extra new line. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/browser/data_reduction_proxy_params.h
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_params.h b/components/data_reduction_proxy/browser/data_reduction_proxy_params.h
index fbcc394d0358b2bfa1e93a44a4f1be4e452c97c1..e7841e30cde31607578631aded16a6a8c06795a8 100644
--- a/components/data_reduction_proxy/browser/data_reduction_proxy_params.h
+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_params.h
@@ -178,6 +178,17 @@ class DataReductionProxyParams {
return configured_on_command_line_;
}
+ // Returns the corresponding string from preprocessor constants if defined,
+ // and an empty string otherwise.
+ virtual std::string GetDefaultDevOrigin() const;
bengr 2014/07/18 19:41:44 These shouldn't be public.
Not at Google. Contact bengr 2014/07/21 17:46:25 We need to access this from io_thread.cc for now.
+ virtual std::string GetDefaultOrigin() const;
+ virtual std::string GetDefaultFallbackOrigin() const;
+ virtual std::string GetDefaultSSLOrigin() const;
+ virtual std::string GetDefaultAltOrigin() const;
+ virtual std::string GetDefaultAltFallbackOrigin() const;
+ virtual std::string GetDefaultProbeURL() const;
+ virtual std::string GetDefaultWarmupURL() const;
+
protected:
// Test constructor that optionally won't call Init();
DataReductionProxyParams(int flags,
@@ -192,17 +203,6 @@ class DataReductionProxyParams {
// line flags and preprocessor constants.
void InitWithoutChecks();
- // Returns the corresponding string from preprocessor constants if defined,
- // and an empty string otherwise.
- virtual std::string GetDefaultDevOrigin() const;
- virtual std::string GetDefaultOrigin() const;
- virtual std::string GetDefaultFallbackOrigin() const;
- virtual std::string GetDefaultSSLOrigin() const;
- virtual std::string GetDefaultAltOrigin() const;
- virtual std::string GetDefaultAltFallbackOrigin() const;
- virtual std::string GetDefaultProbeURL() const;
- virtual std::string GetDefaultWarmupURL() const;
-
private:
GURL origin_;
GURL fallback_origin_;

Powered by Google App Engine
This is Rietveld 408576698