Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: chrome/browser/chrome_browser_field_trials_mobile.cc

Issue 382313003: Add data reduction functionality to all platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove extra new line. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_field_trials_mobile.cc
diff --git a/chrome/browser/chrome_browser_field_trials_mobile.cc b/chrome/browser/chrome_browser_field_trials_mobile.cc
index 3bc52cbd0175dde139a97ef8d88295f97ccd9682..6df55403ac796c2f0f394e9714d0b6a31bafc56b 100644
--- a/chrome/browser/chrome_browser_field_trials_mobile.cc
+++ b/chrome/browser/chrome_browser_field_trials_mobile.cc
@@ -10,7 +10,6 @@
#include "base/metrics/field_trial.h"
#include "base/prefs/pref_service.h"
#include "chrome/common/chrome_switches.h"
-#include "chrome/common/chrome_version_info.h"
#if defined(OS_ANDROID)
#include "chrome/browser/prerender/prerender_field_trial.h"
@@ -18,62 +17,7 @@
namespace chrome {
-namespace {
-
-// Base function used by all data reduction proxy field trials. A trial is
-// only conducted for installs that are in the "Enabled" group. They are always
-// enabled on DEV and BETA channels, and for STABLE, a percentage will be
-// controlled from the server. Until the percentage is learned from the server,
-// a client-side configuration is used.
-void DataCompressionProxyBaseFieldTrial(
- const char* trial_name,
- const base::FieldTrial::Probability enabled_group_probability,
- const base::FieldTrial::Probability total_probability) {
- const char kEnabled[] = "Enabled";
- const char kDisabled[] = "Disabled";
-
- // Find out if this is a stable channel.
- const bool kIsStableChannel =
- chrome::VersionInfo::GetChannel() == chrome::VersionInfo::CHANNEL_STABLE;
-
- // Experiment enabled until Jan 1, 2015. By default, disabled.
- scoped_refptr<base::FieldTrial> trial(
- base::FieldTrialList::FactoryGetFieldTrial(
- trial_name,
- total_probability,
- kDisabled, 2015, 1, 1, base::FieldTrial::ONE_TIME_RANDOMIZED, NULL));
-
- // Non-stable channels will run with probability 1.
- const int kEnabledGroup = trial->AppendGroup(
- kEnabled,
- kIsStableChannel ? enabled_group_probability : total_probability);
-
- const int v = trial->group();
- VLOG(1) << trial_name << " enabled group id: " << kEnabledGroup
- << ". Selected group id: " << v;
-}
-
-void DataCompressionProxyFieldTrials() {
- // Governs the rollout of the compression proxy for Chrome on mobile
- // platforms. In all channels, the percentage will be controlled from the
- // server, and is configured to be 100% = 1000 / 1000 until overridden by the
- // server.
- DataCompressionProxyBaseFieldTrial(
- "DataCompressionProxyRollout", 1000, 1000);
-
- // Governs the rollout of the _promo_ for the compression proxy
- // independently from the rollout of compression proxy. The enabled
- // percentage is configured to be 10% = 100 / 1000 until overridden by the
- // server. When this trial is "Enabled," users get a promo, whereas
- // otherwise, compression is available without a promo.
- DataCompressionProxyBaseFieldTrial(
- "DataCompressionProxyPromoVisibility", 100, 1000);
-}
-
-} // namespace
-
void SetupMobileFieldTrials(const CommandLine& parsed_command_line) {
- DataCompressionProxyFieldTrials();
#if defined(OS_ANDROID)
prerender::ConfigurePrerender(parsed_command_line);
#endif

Powered by Google App Engine
This is Rietveld 408576698