Add data reduction functionality to all platforms.

net/http/http_log_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_log_util.h"
 
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "net/http/http_auth_challenge_tokenizer.h"
 #include "net/http/http_util.h"
@@ skipping 16 matching lines @@
   // Ignore Basic and Digest authentication challenges, as they contain
   // public information.
   if (scheme == "basic" || scheme == "digest")
     return false;
 
   return true;
 }
 
 }  // namespace
 
-#if defined(SPDY_PROXY_AUTH_ORIGIN)
 void ElideChromeProxyDirective(const std::string& header_value,
                                const std::string& directive,
                                std::string::const_iterator* redact_begin,
                                std::string::const_iterator* redact_end) {
   HttpUtil::ValuesIterator it(header_value.begin(), header_value.end(), ',');
   while (it.GetNext()) {
     if (LowerCaseEqualsASCII(it.value_begin(),
                              it.value_begin() + directive.size(),
                              directive.c_str())) {
       *redact_begin = it.value_begin();
       *redact_end = it.value_end();
       return;
     }
   }
 }

[Ryan Sleevi, 2014/08/28 17:21:01]

You still haven't removed/resolved this, which is a core concern that I raised.

[Not at Google. Contact bengr, 2014/08/28 18:59:28]

This is the only remainging layer violation. I thought we agreed that while this
is very important, it wasn't worth blocking the rest of this cl over. I have bug
https://code.google.com/p/chromium/issues/detail?id=396807 filed against me for
this purpose, and will get to this next. Prefer getting this cl in and then
fixing this violation.

[Ryan Sleevi, 2014/09/02 19:30:10]

M-38 has shipped. This code is for M-39, that bug is targetted for M39, I would
want to see how you intend to solve this for M39, at the least, to be
comfortable accepting new technical debt into this.

Again, to reiterate, my very real concern is that once you launch this, with the
whole host of new issues that desktop (and ChromeOS, even if that's all this
targets) introduce, and that you will spend your time chasing down bugs or
regressions rather than getting to that.

Considering this has happened in the past several times, I feel it's important
that we do the right thing here, especially with several weeks left of M39.

[Not at Google. Contact bengr, 2014/09/04 22:45:40]

I am in the process of finding an approach to this with help from net-dev.

Is this the only outstanding issue for this cl? If not, can you please review
the rest of it so that once we remove the layering violation in this file, this
cl is good to go.

This cl is the first of a few we need to land to have the Flywheel working on
desktop in M39, so this cl needs to land as soon as possible rather than towards
the end of M39.

-#endif
 
 std::string ElideHeaderValueForNetLog(NetLog::LogLevel log_level,
                                       const std::string& header,
                                       const std::string& value) {
   std::string::const_iterator redact_begin = value.begin();
   std::string::const_iterator redact_end = value.begin();
-#if defined(SPDY_PROXY_AUTH_ORIGIN)
   if (!base::strcasecmp(header.c_str(), "chrome-proxy")) {

[Ryan Sleevi, 2014/08/28 17:21:01]

This is still a layering violation.

[Not at Google. Contact bengr, 2014/08/28 18:59:28]

Same as above.

     ElideChromeProxyDirective(value, "sid=", &redact_begin, &redact_end);
   }
-#endif
 
   if (redact_begin == redact_end &&
       log_level >= NetLog::LOG_STRIP_PRIVATE_DATA) {
 
     // Note: this logic should be kept in sync with stripCookiesAndLoginInfo in
     // chrome/browser/resources/net_internals/log_view_painter.js.
 
     if (!base::strcasecmp(header.c_str(), "set-cookie") ||
         !base::strcasecmp(header.c_str(), "set-cookie2") ||
         !base::strcasecmp(header.c_str(), "cookie") ||
@@ skipping 16 matching lines @@
   if (redact_begin == redact_end)
     return value;
 
   return std::string(value.begin(), redact_begin) +
       base::StringPrintf("[%ld bytes were stripped]",
                          static_cast<long>(redact_end - redact_begin)) +
       std::string(redact_end, value.end());
 }
 
 }  // namespace net