Add data reduction functionality to all platforms.

components/data_reduction_proxy/common/data_reduction_proxy_headers.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/data_reduction_proxy/common/data_reduction_proxy_headers.h"
 
 #include <string>
 
+#include "base/rand_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_util.h"
 #include "base/time/time.h"
 #include "net/http/http_response_headers.h"
 #include "net/http/http_status_code.h"
 #include "net/proxy/proxy_service.h"
 
 using base::StringPiece;
 using base::TimeDelta;
 using net::ProxyService;
 
 namespace data_reduction_proxy {
 
-bool GetDataReductionProxyBypassDuration(
+namespace {
+
+// Sets a random bypass duration between 1 and 5 minutes.
+void SetRandBypassDuration(DataReductionProxyInfo* data_reduction_proxy_info) {

[bengr, 2014/07/18 19:41:44]

I still think this can be a base:TimeDelta*

[bengr, 2014/07/18 19:41:44]

DCHECK that this isn't NULL.

[Not at Google. Contact bengr, 2014/07/21 17:46:26]

Done.

[Not at Google. Contact bengr, 2014/07/21 17:46:26]

Done.

+  data_reduction_proxy_info->bypass_duration = TimeDelta::FromMilliseconds(
+      base::RandInt(1 * 60 * 1000, 5 * 60 * 1000));
+}
+
+}  // namespace anonymous
+
+bool ParseHeadersAndSetProxyInfoBypassDuration(
     const net::HttpResponseHeaders* headers,
     const std::string& action_prefix,
-    base::TimeDelta* duration) {
+    DataReductionProxyInfo* proxy_info) {
   void* iter = NULL;
   std::string value;
   std::string name = "chrome-proxy";
 
   while (headers->EnumerateHeader(&iter, name, &value)) {
     if (value.size() > action_prefix.size()) {
       if (LowerCaseEqualsASCII(value.begin(),
                                value.begin() + action_prefix.size(),
                                action_prefix.c_str())) {
         int64 seconds;
         if (!base::StringToInt64(
                 StringPiece(value.begin() + action_prefix.size(), value.end()),
                 &seconds) || seconds < 0) {
           continue;  // In case there is a well formed instruction.
         }
-        *duration = TimeDelta::FromSeconds(seconds);
+        if (seconds != 0) {
+          proxy_info->bypass_duration = TimeDelta::FromSeconds(seconds);
+        } else {
+          // Server deferred to us to choose a duration. Default to a range from
+          // one to five minutes.
+          SetRandBypassDuration(proxy_info);
+        }
         return true;
       }
     }
   }
   return false;
 }
 
-bool GetDataReductionProxyInfo(const net::HttpResponseHeaders* headers,
-                               DataReductionProxyInfo* proxy_info) {
+bool ParseHeadersAndSetProxyInfo(const net::HttpResponseHeaders* headers,
+                                 DataReductionProxyInfo* proxy_info) {
   DCHECK(proxy_info);
   proxy_info->bypass_all = false;
-  proxy_info->bypass_duration = TimeDelta();
+
   // Support header of the form Chrome-Proxy: bypass|block=<duration>, where
   // <duration> is the number of seconds to wait before retrying
   // the proxy. If the duration is 0, then the default proxy retry delay
   // (specified in |ProxyList::UpdateRetryInfoOnFallback|) will be used.
   // 'bypass' instructs Chrome to bypass the currently connected data reduction
   // proxy, whereas 'block' instructs Chrome to bypass all available data
   // reduction proxies.
 
   // 'block' takes precedence over 'bypass', so look for it first.
   // TODO(bengr): Reduce checks for 'block' and 'bypass' to a single loop.
-  if (GetDataReductionProxyBypassDuration(
-      headers, "block=", &proxy_info->bypass_duration)) {
+  if (ParseHeadersAndSetProxyInfoBypassDuration(

[bengr, 2014/07/18 19:41:44]

You're in a file with the name "headers" it it, so it is implied that you are
getting the duration from the headers. No need to change the name.

[Not at Google. Contact bengr, 2014/07/21 17:46:26]

My attempt was to make it less ambiguous. I had initially assumed that the
return value would be the bypass duration. Also, wasn't obvious to me that it
was being parsed from the header.

If you have a strong preference for the original, I can revert:)

+      headers, "block=", proxy_info)) {
     proxy_info->bypass_all = true;
     return true;
   }
 
   // Next, look for 'bypass'.
-  if (GetDataReductionProxyBypassDuration(
-      headers, "bypass=", &proxy_info->bypass_duration)) {
+  if (ParseHeadersAndSetProxyInfoBypassDuration(
+      headers, "bypass=", proxy_info)) {
     return true;
   }
   return false;
 }
 
 bool HasDataReductionProxyViaHeader(const net::HttpResponseHeaders* headers) {
   const size_t kVersionSize = 4;
   const char kDataReductionProxyViaValue[] = "Chrome-Compression-Proxy";
   size_t value_len = strlen(kDataReductionProxyViaValue);
   void* iter = NULL;
@@ skipping 19 matching lines @@
   return false;
 }
 
 const int kShortBypassMaxSeconds = 59;
 const int kMediumBypassMaxSeconds = 300;
 net::ProxyService::DataReductionProxyBypassType
 GetDataReductionProxyBypassType(
     const net::HttpResponseHeaders* headers,
     DataReductionProxyInfo* data_reduction_proxy_info) {
   DCHECK(data_reduction_proxy_info);
-  if (GetDataReductionProxyInfo(headers, data_reduction_proxy_info)) {
+  if (ParseHeadersAndSetProxyInfo(headers, data_reduction_proxy_info)) {
     // A chrome-proxy response header is only present in a 502. For proper
     // reporting, this check must come before the 5xx checks below.
     const TimeDelta& duration = data_reduction_proxy_info->bypass_duration;
     if (duration <= TimeDelta::FromSeconds(kShortBypassMaxSeconds))
       return ProxyService::SHORT_BYPASS;
     if (duration <= TimeDelta::FromSeconds(kMediumBypassMaxSeconds))
       return ProxyService::MEDIUM_BYPASS;
     return ProxyService::LONG_BYPASS;
   }
+
   // Fall back if a 500, 502 or 503 is returned.
-  if (headers->response_code() == net::HTTP_INTERNAL_SERVER_ERROR)
-    return ProxyService::STATUS_500_HTTP_INTERNAL_SERVER_ERROR;
-  if (headers->response_code() == net::HTTP_BAD_GATEWAY)
-    return ProxyService::STATUS_502_HTTP_BAD_GATEWAY;
-  if (headers->response_code() == net::HTTP_SERVICE_UNAVAILABLE)
-    return ProxyService::STATUS_503_HTTP_SERVICE_UNAVAILABLE;
+  if (headers->response_code() == net::HTTP_INTERNAL_SERVER_ERROR ||
+      headers->response_code() == net::HTTP_BAD_GATEWAY ||
+      headers->response_code() == net::HTTP_SERVICE_UNAVAILABLE) {
+    SetRandBypassDuration(data_reduction_proxy_info);
+
+    if (headers->response_code() == net::HTTP_INTERNAL_SERVER_ERROR)
+      return ProxyService::STATUS_500_HTTP_INTERNAL_SERVER_ERROR;
+    if (headers->response_code() == net::HTTP_BAD_GATEWAY)
+      return ProxyService::STATUS_502_HTTP_BAD_GATEWAY;
+    if (headers->response_code() == net::HTTP_SERVICE_UNAVAILABLE)
+      return ProxyService::STATUS_503_HTTP_SERVICE_UNAVAILABLE;
+  }
+
   // TODO(kundaji): Bypass if Proxy-Authenticate header value cannot be
   // interpreted by data reduction proxy.
   if (headers->response_code() == net::HTTP_PROXY_AUTHENTICATION_REQUIRED &&
       !headers->HasHeader("Proxy-Authenticate")) {
+    SetRandBypassDuration(data_reduction_proxy_info);
     return ProxyService::MALFORMED_407;
   }
   if (!HasDataReductionProxyViaHeader(headers) &&
       (headers->response_code() != net::HTTP_NOT_MODIFIED)) {
+    SetRandBypassDuration(data_reduction_proxy_info);
     // A Via header might not be present in a 304. Since the goal of a 304
     // response is to minimize information transfer, a sender in general
     // should not generate representation metadata other than Cache-Control,
     // Content-Location, Date, ETag, Expires, and Vary.
 
     // The proxy Via header might also not be present in a 4xx response.
     // Separate this case from other responses that are missing the header.
     if (headers->response_code() >= net::HTTP_BAD_REQUEST &&
         headers->response_code() < net::HTTP_INTERNAL_SERVER_ERROR) {
       return ProxyService::MISSING_VIA_HEADER_4XX;
     }
     return ProxyService::MISSING_VIA_HEADER_OTHER;
   }
   // There is no bypass event.
   return ProxyService::BYPASS_EVENT_TYPE_MAX;
 }
 
 }  // namespace data_reduction_proxy