Add data reduction functionality to all platforms.

chrome/browser/profiles/profile_io_data.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_
 
 #include <map>
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/callback_forward.h"
 #include "base/files/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/prefs/pref_member.h"
 #include "base/synchronization/lock.h"
 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
 #include "chrome/browser/io_thread.h"
 #include "chrome/browser/net/chrome_url_request_context.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/storage_partition_descriptor.h"
 #include "chrome/common/content_settings_types.h"
+#include "components/data_reduction_proxy/browser/data_reduction_proxy_settings.h"
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/resource_context.h"
 #include "net/cookies/cookie_monster.h"
 #include "net/http/http_cache.h"
 #include "net/http/http_network_session.h"
 #include "net/url_request/url_request_job_factory.h"
 
 class ChromeHttpUserAgentSettings;
 class ChromeNetworkDelegate;
@@ skipping 299 matching lines @@
     prerender::PrerenderTracker* prerender_tracker;
   };
 
   explicit ProfileIOData(Profile::ProfileType profile_type);
 
   static std::string GetSSLSessionCacheShard();
 
   void InitializeOnUIThread(Profile* profile);
   void ApplyProfileParamsToContext(ChromeURLRequestContext* context) const;
 
-#if defined(OS_ANDROID)
-#if defined(SPDY_PROXY_AUTH_ORIGIN)
-  void SetDataReductionProxyUsageStatsOnIOThread(IOThread* io_thread,
-                                                 Profile* profile);
-  void SetDataReductionProxyUsageStatsOnUIThread(Profile* profile,
+  // Setup data reduction proxy for given profile with params and usage_stats
+  // from io thread globals.

[bengr, 2014/07/18 19:41:44]

for given --> for the given

params --> |params|
usage_stats -> |usage_stats| 
io thread globals. --> |IOThread::Globals|.

In general, I prefer using || to separate code from text. I'm not sure what the
owners here prefer.

[Not at Google. Contact bengr, 2014/07/21 17:46:25]

Done.

+  void SetupDataReductionProxyOnIOThread(IOThread* io_thread,
+                                         Profile* profile);
+
+  // Setup data reduction proxy for given profile, params, and usage_stats.

[bengr, 2014/07/18 19:41:44]

Say something about ownership. Is ownership retained by the caller?

[Not at Google. Contact bengr, 2014/07/21 17:46:25]

As discussed, I no longer instantiate the settings because it causes threading
issues, so this hasn't changed.

+  void SetupDataReductionProxyOnUIThread(Profile* profile,
+      data_reduction_proxy::DataReductionProxyParams* params,
       data_reduction_proxy::DataReductionProxyUsageStats* usage_stats);
-#endif
-#endif
 
   scoped_ptr<net::URLRequestJobFactory> SetUpJobFactoryDefaults(
       scoped_ptr<net::URLRequestJobFactoryImpl> job_factory,
       content::URLRequestInterceptorScopedVector request_interceptors,
       scoped_ptr<ProtocolHandlerRegistry::JobInterceptorFactory>
           protocol_handler_interceptor,
       net::NetworkDelegate* network_delegate,
       net::FtpTransactionFactory* ftp_transaction_factory) const;
 
   // Called when the profile is destroyed.
@@ skipping 250 matching lines @@
       supervised_user_url_filter_;
 #endif
 
   mutable scoped_ptr<DevToolsNetworkController> network_controller_;
 
   // TODO(jhawkins): Remove once crbug.com/102004 is fixed.
   bool initialized_on_UI_thread_;
 
   const Profile::ProfileType profile_type_;
 
+  scoped_ptr<data_reduction_proxy::DataReductionProxySettings>

[bengr, 2014/07/18 19:41:44]

Shouldn't this only be declared for non-Android/iOS?

[Not at Google. Contact bengr, 2014/07/21 17:46:25]

Removed.

+      data_reduction_proxy_settings_;

[bengr, 2014/07/18 19:41:44]

Optional: Style isn't clear on whether the second line of a variable declaration
should be indented. I prefer not.

[Not at Google. Contact bengr, 2014/07/21 17:46:25]

Removed.

I thought this would be treated like any other statement, and so next line would
indent?

+
   DISALLOW_COPY_AND_ASSIGN(ProfileIOData);
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_