ui/gfx/render_text_harfbuzz.cc - Issue 382273002: ui/gfx: Allow for font-specific rendering settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text_harfbuzz.cc

Issue 382273002: ui/gfx: Allow for font-specific rendering settings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: diff against https://codereview.chromium.org/387743002/ Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/render_text_harfbuzz.cc

diff --git a/ui/gfx/render_text_harfbuzz.cc b/ui/gfx/render_text_harfbuzz.cc

index a56552580389998a9c559cafd41af252ac9ecf32..4908fe0e11b2d1eff30f3353acf33574e9705c5e 100644

--- a/ui/gfx/render_text_harfbuzz.cc

+++ b/ui/gfx/render_text_harfbuzz.cc

@@ -779,8 +779,7 @@ void RenderTextHarfBuzz::DrawVisualText(Canvas* canvas) {

ApplyTextShadows(&renderer);

#if defined(OS_WIN) || defined(OS_LINUX)

- // TODO(derat): Use font-specific params: http://crbug.com/125235

- renderer.SetFontRenderParams(GetDefaultFontRenderParams(),

+ renderer.SetFontRenderParams(font_list().GetFontRenderParams(),

background_is_transparent());

#endif