ui/gfx: Allow for font-specific rendering settings.

ui/gfx/font_render_params.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_FONT_RENDER_PARAMS_H_
 #define UI_GFX_FONT_RENDER_PARAMS_H_
 
+#include <string>
+#include <vector>
+
 #include "ui/gfx/gfx_export.h"
 
 namespace gfx {
 
 // A collection of parameters describing how text should be rendered on Linux.
 struct GFX_EXPORT FontRenderParams {
   FontRenderParams();
   ~FontRenderParams();
 
   // Level of hinting to be applied.
@@ skipping 32 matching lines @@
   Hinting hinting;
 
   // Whether subpixel rendering should be used or not, and if so, the display's
   // subpixel order.
   SubpixelRendering subpixel_rendering;
 };
 
 // Returns the system's default parameters for font rendering.
 GFX_EXPORT const FontRenderParams& GetDefaultFontRenderParams();
 
 // Returns the system's default parameters for WebKit font rendering.

[msw, 2014/07/12 00:27:31]

optional [followup] nit: update the WebKit name and comment here too.

[Daniel Erat, 2014/07/12 01:55:32]

added a todo and will do it in a later change (since it requires touching
additional files)

[msw, 2014/07/12 02:26:40]

sgtm, thanks

 GFX_EXPORT const FontRenderParams& GetDefaultWebKitFontRenderParams();
 
+// Returns the appropriate parameters for rendering the font described by the
+// passed-in-arguments, any of which may be NULL. If |family_out| is non-NULL,
+// it will be updated to contain the recommended font family from |family_list|.
+GFX_EXPORT FontRenderParams GetCustomFontRenderParams(
+    bool renderer,

[msw, 2014/07/12 00:27:32]

nit: clarify this in name |for_web_contents|? or in comment.

[Daniel Erat, 2014/07/12 01:55:32]

Done.

+    const std::vector<std::string>* family_list,
+    const int* pixel_size,
+    const int* point_size,
+    std::string* family_out);

[Daniel Erat, 2014/07/11 17:15:29]

returning the font family here seems a bit out of place, but we'd have to do two
identical fontconfig queries instead of one otherwise.

[msw, 2014/07/12 00:27:31]

Acknowledged.

+
 // Returns the system's default parameters for WebKit subpixel positioning.

[msw, 2014/07/12 00:27:31]

optional [followup] nit: update the WebKit name and comment here too. Or maybe
the *one* caller could just use GetDefaultWebKitFontRenderParams instead?

[Daniel Erat, 2014/07/12 01:55:32]

done (my favorite part is "WebKit" in the earlier function's name vs. "Webkit"
in this function)

 // Subpixel positioning is special since neither GTK nor FontConfig currently
 // track it as a preference.
 // See https://bugs.freedesktop.org/show_bug.cgi?id=50736
 GFX_EXPORT bool GetDefaultWebkitSubpixelPositioning();
 
 }  // namespace gfx
 
 #endif  // UI_GFX_FONT_RENDER_PARAMS_H_