Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 382243005: Use unpremul for premul_and_unpremul_alpha_ bench. (Closed)

Created:
6 years, 5 months ago by scroggo
Modified:
6 years, 5 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Use unpremul for premul_and_unpremul_alpha_ bench. Using the wrong color type resulted in invalid colors. Committed: https://skia.googlesource.com/skia/+/fa04776d3a63255ee11fed311a69b25b5f507736

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M bench/PremulAndUnpremulAlphaOpsBench.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scroggo
6 years, 5 months ago (2014-07-11 17:16:03 UTC) #1
bsalomon
lgtm
6 years, 5 months ago (2014-07-11 17:18:19 UTC) #2
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 5 months ago (2014-07-11 17:21:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/382243005/1
6 years, 5 months ago (2014-07-11 17:21:40 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 17:45:15 UTC) #5
Message was sent while issue was closed.
Change committed as fa04776d3a63255ee11fed311a69b25b5f507736

Powered by Google App Engine
This is Rietveld 408576698