components/autofill/core/browser/autofill_country.h - Issue 382243002: Cleanup return values in autofill

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_country.h

Issue 382243002: Cleanup return values in autofill (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert unwanted changes Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/autofill_country.h

diff --git a/components/autofill/core/browser/autofill_country.h b/components/autofill/core/browser/autofill_country.h

index 17bb74c49f6ac25b6da886129f9fa603b825300f..7b2414f232b6b5284092146217a0ea7f2fa53982 100644

--- a/components/autofill/core/browser/autofill_country.h

+++ b/components/autofill/core/browser/autofill_country.h

@@ -61,10 +61,10 @@ class AutofillCountry {

static const std::string GetCountryCode(const base::string16& country,

const std::string& locale);

- const std::string country_code() const { return country_code_; }

- const base::string16 name() const { return name_; }

- const base::string16 postal_code_label() const { return postal_code_label_; }

- const base::string16 state_label() const { return state_label_; }

+ const std::string& country_code() const { return country_code_; }

+ const base::string16& name() const { return name_; }

+ const base::string16& postal_code_label() const { return postal_code_label_; }

+ const base::string16& state_label() const { return state_label_; }

// City is expected in a complete address for this country.

bool requires_city() const {

« no previous file with comments | « no previous file | no next file » | no next file with comments »