Issue 382193004: Print callstack in _ASSERT_TRUE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 382193004: Print callstack in _ASSERT_TRUE (Closed)

Created:
6 years, 5 months ago by kelvinp

Modified:
6 years, 5 months ago

Reviewers:
anandc, Jamie

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Print callstack in _ASSERT_TRUE. ASSERT_TRUE only prints the first call frame in the error message. In our case, this is the _ASSERT_TRUE wrapper function, which is not useful. To help with debugging, this CL dumps the full stack. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282737

Patch Set 1 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/test/remoting/remote_desktop_browsertest.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kelvinp@chromium.org/382193004/20001

6 years, 5 months ago (2014-07-11 20:35:23 UTC) #4

Message was sent while issue was closed.

Change committed as 282737

Expand Messages | Collapse Messages