Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 382153006: Fix 'except' and 'prefer' spelling. (Closed)

Created:
6 years, 5 months ago by Thiemo Nagel
Modified:
6 years, 5 months ago
CC:
chromium-reviews, jam, markusheintz_, stevenjb+watch_chromium.org, oshima+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix 'except' and 'prefer' spelling. TBR=marja, stevenjb, yosin BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283419

Patch Set 1 #

Total comments: 2

Patch Set 2 : More spelling fixes. #

Patch Set 3 : Drop change to braille_table.js because it fails CQ. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M build/install-chroot.sh View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_policy_provider.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/history/history_service.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/process_singleton.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chromeos/system/statistics_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/data_type_manager_impl_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/appcache/appcache_storage_impl_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/data/dom_storage/sanity_check.js View 1 chunk +2 lines, -2 lines 0 comments Download
M media/video/capture/linux/video_capture_device_linux.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webkit_strings.grd View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Thiemo Nagel
cyptal?
6 years, 5 months ago (2014-07-11 12:05:00 UTC) #1
pneubeck (no reviews)
On 2014/07/11 12:05:00, Thiemo Nagel wrote: > cyptal? cryptic?
6 years, 5 months ago (2014-07-11 13:18:25 UTC) #2
pneubeck (no reviews)
iydalosc,ysoabfi. or more verbose for people who can't test all combinations of matching words for ...
6 years, 5 months ago (2014-07-11 13:20:41 UTC) #3
Thiemo Nagel
On 2014/07/11 13:20:41, pneubeck wrote: > iydalosc,ysoabfi. Thank you for your advice. I've found some ...
6 years, 5 months ago (2014-07-11 15:53:51 UTC) #4
Thiemo Nagel
https://codereview.chromium.org/382153006/diff/1/chrome/browser/content_settings/content_settings_policy_provider.cc File chrome/browser/content_settings/content_settings_policy_provider.cc (right): https://codereview.chromium.org/382153006/diff/1/chrome/browser/content_settings/content_settings_policy_provider.cc#newcode223 chrome/browser/content_settings/content_settings_policy_provider.cc:223: // in parallel to the preference default content settings. ...
6 years, 5 months ago (2014-07-11 15:54:23 UTC) #5
pneubeck (no reviews)
lgtm
6 years, 5 months ago (2014-07-11 16:05:45 UTC) #6
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 5 months ago (2014-07-11 16:11:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/382153006/20001
6 years, 5 months ago (2014-07-11 16:12:06 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-11 18:41:24 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-11 18:45:45 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/79450)
6 years, 5 months ago (2014-07-11 18:45:46 UTC) #11
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 5 months ago (2014-07-16 10:25:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/382153006/40001
6 years, 5 months ago (2014-07-16 10:25:37 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 17:53:25 UTC) #14
Message was sent while issue was closed. 
Change committed as 283419

Powered by Google App Engine
This is Rietveld 408576698