Make sure read/write buffer alive in TCPSocketLibevent.

net/socket/tcp_socket_libevent.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_TCP_SOCKET_LIBEVENT_H_
 #define NET_SOCKET_TCP_SOCKET_LIBEVENT_H_
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/compiler_specific.h"
@@ skipping 130 matching lines @@
                             IPEndPoint* address,
                             int rv);
   int BuildTcpSocketLibevent(scoped_ptr<TCPSocketLibevent>* tcp_socket,
                              IPEndPoint* address);
 
   void ConnectCompleted(const CompletionCallback& callback, int rv) const;
   int HandleConnectCompleted(int rv) const;
   void LogConnectBegin(const AddressList& addresses) const;
   void LogConnectEnd(int net_error) const;
 
-  void ReadCompleted(IOBuffer* buf,
+  // Binds with scoped_refptr<IOBuffer> instead of IOBuffer* to make sure buf
+  // alive when this callback is called.
+  void ReadCompleted(const scoped_refptr<IOBuffer>& buf,
                      const CompletionCallback& callback,
                      int rv);
   int HandleReadCompleted(IOBuffer* buf, int rv);
 
-  void WriteCompleted(IOBuffer* buf,
+  // Binds with scoped_refptr<IOBuffer> instead of IOBuffer* to make sure buf
+  // alive when this callback is called.

[Ryan Sleevi, 2014/07/11 19:04:43]

I don't think either of these comments are needed/beneficial, at least within
the header.

[byungchul, 2014/07/11 21:35:52]

Moved to .cc

+  void WriteCompleted(const scoped_refptr<IOBuffer>& buf,
                       const CompletionCallback& callback,
                       int rv) const;
   int HandleWriteCompleted(IOBuffer* buf, int rv) const;
   int TcpFastOpenWrite(IOBuffer* buf,
                        int buf_len,
                        const CompletionCallback& callback);
 
   // Called when the socket is known to be in a connected state.
   void RecordFastOpenStatus();
 
@@ skipping 11 matching lines @@
   bool logging_multiple_connect_attempts_;
 
   BoundNetLog net_log_;
 
   DISALLOW_COPY_AND_ASSIGN(TCPSocketLibevent);
 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_TCP_SOCKET_LIBEVENT_H_