chrome/browser/android/dev_tools_server.h - Issue 382143005: Supports DevTools socket access authentication based on Android permissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/dev_tools_server.h

Issue 382143005: Supports DevTools socket access authentication based on Android permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Commented process_id Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/DevToolsServer.java ('k') | chrome/browser/android/dev_tools_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/dev_tools_server.h

diff --git a/chrome/browser/android/dev_tools_server.h b/chrome/browser/android/dev_tools_server.h

index 46a0870af4a6229d0c96b7bf79b20280557a153e..67f56889b1a7b2f4402462bf42e5ba13f5dc7570 100644

--- a/chrome/browser/android/dev_tools_server.h

+++ b/chrome/browser/android/dev_tools_server.h

@@ -16,14 +16,11 @@ class DevToolsHttpHandler;

// This class controls Developer Tools remote debugging server.

class DevToolsServer {

public:

- // TODO(mnaganov): Remove the prefixless constructor after having its

- // usage removed in the Chrome for Android code.

- DevToolsServer();

explicit DevToolsServer(const std::string& socket_name_prefix);

~DevToolsServer();

// Opens linux abstract socket to be ready for remote debugging.

- void Start();

+ void Start(bool allow_debug_permission);

// Closes debugging socket, stops debugging.

void Stop();