content/browser/android/devtools_auth.cc - Issue 382143005: Supports DevTools socket access authentication based on Android permissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/devtools_auth.cc

Issue 382143005: Supports DevTools socket access authentication based on Android permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merged Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/dev_tools_server.cc ('K') | « chrome/browser/android/dev_tools_server.cc ('k') | content/public/browser/android/devtools_auth.h » ('j') | net/socket/unix_domain_server_socket_posix.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/devtools_auth.cc

diff --git a/content/browser/android/devtools_auth.cc b/content/browser/android/devtools_auth.cc

index 777a01e00b0b6e9a20e855fda9e04db3c35528b9..0e07b5280a3b61847b142a017e1217161f258689 100644

--- a/content/browser/android/devtools_auth.cc

+++ b/content/browser/android/devtools_auth.cc

@@ -11,7 +11,7 @@

namespace content {

-bool CanUserConnectToDevTools(uid_t uid, gid_t gid) {

+bool CanUserConnectToDevTools(pid_t, uid_t uid, gid_t gid) {

struct passwd* creds = getpwuid(uid);

if (!creds || !creds->pw_name) {

LOG(WARNING) << "DevTools: can't obtain creds for uid " << uid;