Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Side by Side Diff: net/socket/unix_domain_server_socket_posix.h

Issue 382143005: Supports DevTools socket access authentication based on Android permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Non-static permission enabling Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_SOCKET_UNIX_DOMAIN_SERVER_SOCKET_POSIX_H_ 5 #ifndef NET_SOCKET_UNIX_DOMAIN_SERVER_SOCKET_POSIX_H_
6 #define NET_SOCKET_UNIX_DOMAIN_SERVER_SOCKET_POSIX_H_ 6 #define NET_SOCKET_UNIX_DOMAIN_SERVER_SOCKET_POSIX_H_
7 7
8 #include <sys/types.h> 8 #include <sys/types.h>
9 9
10 #include <string> 10 #include <string>
11 11
12 #include "base/basictypes.h" 12 #include "base/basictypes.h"
13 #include "base/callback.h" 13 #include "base/callback.h"
14 #include "base/macros.h" 14 #include "base/macros.h"
15 #include "base/memory/scoped_ptr.h" 15 #include "base/memory/scoped_ptr.h"
16 #include "net/base/net_export.h" 16 #include "net/base/net_export.h"
17 #include "net/socket/server_socket.h" 17 #include "net/socket/server_socket.h"
18 #include "net/socket/socket_descriptor.h" 18 #include "net/socket/socket_descriptor.h"
19 19
20 namespace net { 20 namespace net {
21 21
22 class SocketLibevent; 22 class SocketLibevent;
23 23
24 // Unix Domain Server Socket Implementation. Supports abstract namespaces on 24 // Unix Domain Server Socket Implementation. Supports abstract namespaces on
25 // Linux and Android. 25 // Linux and Android.
26 class NET_EXPORT UnixDomainServerSocket : public ServerSocket { 26 class NET_EXPORT UnixDomainServerSocket : public ServerSocket {
27 public: 27 public:
28 // Credentials of a peer process connected to the socket.
29 struct NET_EXPORT Credentials {
30 #if defined(OS_LINUX) || defined(OS_ANDROID)
mmenke 2014/08/07 22:44:18 Sorry, was thinking about a comment specifically a
SeRya 2014/08/08 07:42:20 Done.
31 pid_t process_id;
32 #endif
33 uid_t user_id;
34 gid_t group_id;
35 };
36
28 // Callback that returns whether the already connected client, identified by 37 // Callback that returns whether the already connected client, identified by
29 // its process |user_id| and |group_id|, is allowed to keep the connection 38 // its credentials, is allowed to keep the connection open. Note that
30 // open. Note that the socket is closed immediately in case the callback 39 // the socket is closed immediately in case the callback returns false.
31 // returns false. 40 typedef base::Callback<bool (const Credentials&)> AuthCallback;
32 typedef base::Callback<bool (uid_t user_id, gid_t group_id)> AuthCallback;
33 41
34 UnixDomainServerSocket(const AuthCallback& auth_callack, 42 UnixDomainServerSocket(const AuthCallback& auth_callack,
35 bool use_abstract_namespace); 43 bool use_abstract_namespace);
36 virtual ~UnixDomainServerSocket(); 44 virtual ~UnixDomainServerSocket();
37 45
38 // Gets UID and GID of peer to check permissions. 46 // Gets credentials of peer to check permissions.
39 static bool GetPeerIds(SocketDescriptor socket_fd, 47 static bool GetPeerCredentials(SocketDescriptor socket_fd,
40 uid_t* user_id, 48 Credentials* credentials);
41 gid_t* group_id);
42 49
43 // ServerSocket implementation. 50 // ServerSocket implementation.
44 virtual int Listen(const IPEndPoint& address, int backlog) OVERRIDE; 51 virtual int Listen(const IPEndPoint& address, int backlog) OVERRIDE;
45 virtual int ListenWithAddressAndPort(const std::string& unix_domain_path, 52 virtual int ListenWithAddressAndPort(const std::string& unix_domain_path,
46 int port_unused, 53 int port_unused,
47 int backlog) OVERRIDE; 54 int backlog) OVERRIDE;
48 virtual int GetLocalAddress(IPEndPoint* address) const OVERRIDE; 55 virtual int GetLocalAddress(IPEndPoint* address) const OVERRIDE;
49 virtual int Accept(scoped_ptr<StreamSocket>* socket, 56 virtual int Accept(scoped_ptr<StreamSocket>* socket,
50 const CompletionCallback& callback) OVERRIDE; 57 const CompletionCallback& callback) OVERRIDE;
51 58
52 private: 59 private:
53 void AcceptCompleted(scoped_ptr<StreamSocket>* socket, 60 void AcceptCompleted(scoped_ptr<StreamSocket>* socket,
54 const CompletionCallback& callback, 61 const CompletionCallback& callback,
55 int rv); 62 int rv);
56 bool AuthenticateAndGetStreamSocket(scoped_ptr<StreamSocket>* socket); 63 bool AuthenticateAndGetStreamSocket(scoped_ptr<StreamSocket>* socket);
57 64
58 scoped_ptr<SocketLibevent> listen_socket_; 65 scoped_ptr<SocketLibevent> listen_socket_;
59 const AuthCallback auth_callback_; 66 const AuthCallback auth_callback_;
60 const bool use_abstract_namespace_; 67 const bool use_abstract_namespace_;
61 68
62 scoped_ptr<SocketLibevent> accept_socket_; 69 scoped_ptr<SocketLibevent> accept_socket_;
63 70
64 DISALLOW_COPY_AND_ASSIGN(UnixDomainServerSocket); 71 DISALLOW_COPY_AND_ASSIGN(UnixDomainServerSocket);
65 }; 72 };
66 73
67 } // namespace net 74 } // namespace net
68 75
69 #endif // NET_SOCKET_UNIX_DOMAIN_SOCKET_POSIX_H_ 76 #endif // NET_SOCKET_UNIX_DOMAIN_SOCKET_POSIX_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698