Supports DevTools socket access authentication based on Android permissions.

net/socket/unix_domain_server_socket_posix.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_UNIX_DOMAIN_SERVER_SOCKET_POSIX_H_
 #define NET_SOCKET_UNIX_DOMAIN_SERVER_SOCKET_POSIX_H_
 
 #include <sys/types.h>
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "net/base/net_export.h"
 #include "net/socket/server_socket.h"
 #include "net/socket/socket_descriptor.h"
 
 namespace net {
 
 class SocketLibevent;
 
 // Unix Domain Server Socket Implementation. Supports abstract namespaces on
 // Linux and Android.
 class NET_EXPORT UnixDomainServerSocket : public ServerSocket {
  public:
+  struct Credentials;
+
   // Callback that returns whether the already connected client, identified by
-  // its process |user_id| and |group_id|, is allowed to keep the connection
-  // open. Note that the socket is closed immediately in case the callback
-  // returns false.
-  typedef base::Callback<bool (uid_t user_id, gid_t group_id)> AuthCallback;
+  // its credentials, is allowed to keep the connection open. Note that
+  // the socket is closed immediately in case the callback returns false.
+  typedef base::Callback<bool (const Credentials&)> AuthCallback;
 
   UnixDomainServerSocket(const AuthCallback& auth_callack,
                          bool use_abstract_namespace);
   virtual ~UnixDomainServerSocket();
 
-  // Gets UID and GID of peer to check permissions.
+  // Gets credentials of peer to check permissions.
   static bool GetPeerIds(SocketDescriptor socket_fd,

[byungchul, 2014/08/04 22:18:02]

GetCredentials

[SeRya, 2014/08/05 10:32:27]

Renamed to GetPeerCredentials

-                         uid_t* user_id,
-                         gid_t* group_id);
+                         Credentials* credentials);
 
   // ServerSocket implementation.
   virtual int Listen(const IPEndPoint& address, int backlog) OVERRIDE;
   virtual int ListenWithAddressAndPort(const std::string& unix_domain_path,
                                        int port_unused,
                                        int backlog) OVERRIDE;
   virtual int GetLocalAddress(IPEndPoint* address) const OVERRIDE;
   virtual int Accept(scoped_ptr<StreamSocket>* socket,
                      const CompletionCallback& callback) OVERRIDE;
 
  private:
   void AcceptCompleted(scoped_ptr<StreamSocket>* socket,
                        const CompletionCallback& callback,
                        int rv);
   bool AuthenticateAndGetStreamSocket(scoped_ptr<StreamSocket>* socket);
 
   scoped_ptr<SocketLibevent> listen_socket_;
   const AuthCallback auth_callback_;
   const bool use_abstract_namespace_;
 
   scoped_ptr<SocketLibevent> accept_socket_;
 
   DISALLOW_COPY_AND_ASSIGN(UnixDomainServerSocket);
 };
 
+struct UnixDomainServerSocket::Credentials {

[mmenke, 2014/08/04 20:22:57]

In net/, at least, public inner classes and structs are generally inlined in the
declaration.

[byungchul, 2014/08/04 22:18:02]

need NET_EXPORT

[SeRya, 2014/08/05 10:32:27]

Moved inside.

[SeRya, 2014/08/05 10:32:27]

Done.

+#if defined(OS_LINUX) || defined(OS_ANDROID)
+  pid_t process_id;

[mmenke, 2014/08/04 20:22:57]

Think this is worth a comment (Code is pretty self-explanatory, but a comment
for something unexpected like this still seems a good idea to me).

[SeRya, 2014/08/05 10:32:27]

Done.

+#endif
+  uid_t user_id;
+  gid_t group_id;
+};
+
 }  // namespace net
 
 #endif  // NET_SOCKET_UNIX_DOMAIN_SOCKET_POSIX_H_