Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 382143004: Remove repaint callbacks from Viewport. (Closed)

Created:
6 years, 5 months ago by hirono
Modified:
6 years, 5 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove repaint callbacks from Viewport. To focus geometory calculation, remove the role other than caculation from the Viewport class. BUG=245926 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282602

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -99 lines) Patch
M ui/file_manager/gallery/js/image_editor/image_buffer.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_editor.js View 1 chunk +2 lines, -6 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_view.js View 1 3 chunks +5 lines, -33 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/viewport.js View 1 5 chunks +1 line, -57 lines 0 comments Download
M ui/file_manager/gallery/js/slide_mode.js View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 5 months ago (2014-07-11 06:30:57 UTC) #1
mtomasz
Does drag handler still work after this change? https://code.google.com/p/chromium/codesearch#chromium/src/ui/file_manager/gallery/js/image_editor/image_view.js&l=150 https://codereview.chromium.org/382143004/diff/1/ui/file_manager/gallery/js/image_editor/image_view.js File ui/file_manager/gallery/js/image_editor/image_view.js (right): https://codereview.chromium.org/382143004/diff/1/ui/file_manager/gallery/js/image_editor/image_view.js#newcode103 ui/file_manager/gallery/js/image_editor/image_view.js:103: ...
6 years, 5 months ago (2014-07-11 06:34:12 UTC) #2
hirono
The drag handler is not used. I removed the whole function. https://codereview.chromium.org/382143004/diff/1/ui/file_manager/gallery/js/image_editor/image_view.js File ui/file_manager/gallery/js/image_editor/image_view.js (right): ...
6 years, 5 months ago (2014-07-11 06:41:17 UTC) #3
mtomasz
lgtm!
6 years, 5 months ago (2014-07-11 08:00:39 UTC) #4
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 5 months ago (2014-07-11 08:04:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/382143004/20001
6 years, 5 months ago (2014-07-11 08:05:20 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 09:57:33 UTC) #7
Message was sent while issue was closed.
Change committed as 282602

Powered by Google App Engine
This is Rietveld 408576698