Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm

Issue 382133003: Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moved Browser and GetParent() logic into constructor Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm b/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm
index ca9cf2210a25330c86e85409d4e2f353080649e2..66033102f05d42aa3c71b2a4ffb9c55dde1d765e 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm
@@ -27,10 +27,10 @@ namespace {
class ExtensionUninstallDialogCocoa
: public extensions::ExtensionUninstallDialog {
public:
- ExtensionUninstallDialogCocoa(
- Profile* profile,
- Browser* browser,
- Delegate* delegate);
+ ExtensionUninstallDialogCocoa(Profile* profile,
+ Browser* browser,
+ gfx::NativeWindow parent,
+ Delegate* delegate);
virtual ~ExtensionUninstallDialogCocoa() OVERRIDE;
private:
@@ -40,8 +40,9 @@ class ExtensionUninstallDialogCocoa
ExtensionUninstallDialogCocoa::ExtensionUninstallDialogCocoa(
Profile* profile,
Browser* browser,
+ gfx::NativeWindow parent,
extensions::ExtensionUninstallDialog::Delegate* delegate)
- : extensions::ExtensionUninstallDialog(profile, browser, delegate) {
+ : extensions::ExtensionUninstallDialog(profile, browser, parent, delegate) {
}
ExtensionUninstallDialogCocoa::~ExtensionUninstallDialogCocoa() {}
@@ -76,5 +77,13 @@ extensions::ExtensionUninstallDialog*
extensions::ExtensionUninstallDialog::Create(Profile* profile,
Browser* browser,
Delegate* delegate) {
- return new ExtensionUninstallDialogCocoa(profile, browser, delegate);
+ return new ExtensionUninstallDialogCocoa(profile, browser, NULL, delegate);
+}
+
+// static
+extensions::ExtensionUninstallDialog*
+extensions::ExtensionUninstallDialog::CreateModal(Profile* profile,
+ gfx::NativeWindow parent,
+ Delegate* delegate) {
+ return new ExtensionUninstallDialogCocoa(profile, NULL, parent, delegate);
}

Powered by Google App Engine
This is Rietveld 408576698