Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser

chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm

Index: chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm b/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm
index ca9cf2210a25330c86e85409d4e2f353080649e2..5c07d83ed28f6cccb536e3c63c2cda448b109b1e 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm
@@ -27,10 +27,9 @@ namespace {
 class ExtensionUninstallDialogCocoa
     : public extensions::ExtensionUninstallDialog {
  public:
-  ExtensionUninstallDialogCocoa(
-      Profile* profile,
-      Browser* browser,
-      Delegate* delegate);
+  ExtensionUninstallDialogCocoa(Profile* profile,
+                                gfx::NativeWindow parent,
+                                Delegate* delegate);
   virtual ~ExtensionUninstallDialogCocoa() OVERRIDE;
 
  private:
@@ -39,9 +38,9 @@ class ExtensionUninstallDialogCocoa
 
 ExtensionUninstallDialogCocoa::ExtensionUninstallDialogCocoa(
     Profile* profile,
-    Browser* browser,
+    gfx::NativeWindow parent,
     extensions::ExtensionUninstallDialog::Delegate* delegate)
-    : extensions::ExtensionUninstallDialog(profile, browser, delegate) {
+    : extensions::ExtensionUninstallDialog(profile, parent, delegate) {
 }
 
 ExtensionUninstallDialogCocoa::~ExtensionUninstallDialogCocoa() {}
@@ -76,5 +75,15 @@ extensions::ExtensionUninstallDialog*
 extensions::ExtensionUninstallDialog::Create(Profile* profile,
                                              Browser* browser,
                                              Delegate* delegate) {
-  return new ExtensionUninstallDialogCocoa(profile, browser, delegate);
+  ExtensionUninstallDialogCocoa* dialog =
+      new ExtensionUninstallDialogCocoa(profile, GetParent(browser), delegate);

[tapted, 2014/07/21 03:41:26]

I don't think GetParent is available here

[sashab, 2014/07/22 00:30:43]

No longer needed; GetParent logic is now in the constructor. Done.

+  dialog->RegisterObserver(browser);
+  return dialog;
+}
+// static

[tapted, 2014/07/21 03:41:26]

nit: keep blank line before

[sashab, 2014/07/22 00:30:43]

Done.

+extensions::ExtensionUninstallDialog*
+extensions::ExtensionUninstallDialog::CreateModal(Profile* profile,
+                                                  gfx::NativeWindow parent,
+                                                  Delegate* delegate) {
+  return new ExtensionUninstallDialogCocoa(profile, parent, delegate);
 }