Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3331)

Unified Diff: chrome/browser/extensions/extension_uninstall_dialog.h

Issue 382133003: Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added CreateAsStandaloneDialog for extension_storage_monitor Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_uninstall_dialog.h
diff --git a/chrome/browser/extensions/extension_uninstall_dialog.h b/chrome/browser/extensions/extension_uninstall_dialog.h
index 0d2f112a1ad781feb8fb145e165efd98af28205a..8f26fcbfdc17aaad4950328d3944c73c2a4ff7b8 100644
--- a/chrome/browser/extensions/extension_uninstall_dialog.h
+++ b/chrome/browser/extensions/extension_uninstall_dialog.h
@@ -12,6 +12,7 @@
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
#include "ui/gfx/image/image_skia.h"
+#include "ui/gfx/native_widget_types.h"
class Browser;
class Profile;
@@ -43,14 +44,23 @@ class ExtensionUninstallDialog
virtual ~Delegate() {}
};
- // Creates a platform specific implementation of ExtensionUninstallDialog.
- // |profile| and |delegate| can never be NULL.
- // |browser| can be NULL only for Ash when this is used with the applist
- // window.
+ // Creates a platform-specific implementation of ExtensionUninstallDialog for
+ // the given browser window.
static ExtensionUninstallDialog* Create(Profile* profile,
Browser* browser,
Delegate* delegate);
+ // Create an platform-specific implementation of ExtensionUninstallDialog for
tapted 2014/07/11 06:10:41 nit: an -> a
sashab 2014/07/13 22:57:25 Done.
+ // the app list (or a child widget in the app list).
+ static ExtensionUninstallDialog* CreateForAppList(Profile* profile,
+ gfx::NativeWindow parent,
+ Delegate* delegate);
+
+ // Create an platform-specific implementation of ExtensionUninstallDialog with
tapted 2014/07/11 06:10:40 nit: an -> a
sashab 2014/07/13 22:57:25 Done.
+ // no parent widget (behaves like a standalone window).
+ static ExtensionUninstallDialog* CreateAsStandaloneDialog(Profile* profile,
+ Delegate* delegate);
+
virtual ~ExtensionUninstallDialog();
// This is called to verify whether the uninstallation should proceed.

Powered by Google App Engine
This is Rietveld 408576698