chrome/browser/ui/webui/extensions/extension_settings_handler.cc - Issue 382133003: Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 382133003: Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review feedback & todos for unfixed issues Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

index 735dc6fd2db225661a21e610e53034207b45cda4..6861266552d2308c0b47fa4d876c34c45ea8755b 100644

--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

@@ -47,7 +47,9 @@

#include "chrome/browser/supervised_user/supervised_user_service.h"

#include "chrome/browser/supervised_user/supervised_user_service_factory.h"

#include "chrome/browser/tab_contents/background_contents.h"

+#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_finder.h"

+#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/extensions/application_launch.h"

#include "chrome/browser/ui/webui/extensions/extension_basic_info.h"

#include "chrome/browser/ui/webui/extensions/extension_icon_source.h"

@@ -1369,7 +1371,8 @@ ExtensionSettingsHandler::GetExtensionUninstallDialog() {

web_ui()->GetWebContents());

extension_uninstall_dialog_.reset(

ExtensionUninstallDialog::Create(extension_service_->profile(),

- browser, this));

+ browser->window()->GetNativeWindow(),

+ this));

}

return extension_uninstall_dialog_.get();

#else