chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc - Issue 382133003: Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc

Issue 382133003: Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review feedback & todos for unfixed issues Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm ('k') | chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc

index 26bf4934a49d4b9f1643a0fcfd33453299254df8..abc9bee7d88cfe4dd560b01012f114cf030984ab 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc

@@ -169,7 +169,8 @@ bool AppInfoFooterPanel::CanSetPinnedToShelf() const {

void AppInfoFooterPanel::UninstallApp() {

DCHECK(CanUninstallApp());

extension_uninstall_dialog_.reset(

- extensions::ExtensionUninstallDialog::Create(profile_, NULL, this));

+ extensions::ExtensionUninstallDialog::Create(

+ profile_, GetWidget()->GetNativeWindow(), this));

extension_uninstall_dialog_->ConfirmUninstall(app_);

}