Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser

chrome/browser/extensions/api/management/management_api.cc

Index: chrome/browser/extensions/api/management/management_api.cc
diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc
index 98a48995504b2bf4f6ccdcf145b8c902abad88f9..112bcb82aa00860fd2f46a8f9006a421b4456ee9 100644
--- a/chrome/browser/extensions/api/management/management_api.cc
+++ b/chrome/browser/extensions/api/management/management_api.cc
@@ -611,7 +611,9 @@ bool ManagementUninstallFunctionBase::Uninstall(
     if (show_confirm_dialog) {
       AddRef();  // Balanced in ExtensionUninstallAccepted/Canceled
       extension_uninstall_dialog_.reset(ExtensionUninstallDialog::Create(
-          GetProfile(), GetCurrentBrowser(), this));
+          GetProfile(),
+          GetCurrentBrowser()->window()->GetNativeWindow(),

[tapted, 2014/07/24 07:09:55]

So.. I think there's a pre-existing crash lurking here (http://crbug.com/362308
).

I think the best fix is

  extensions::WindowController* controller = GetExtensionWindowController();
  extension_uninstall_dialog_.reset(ExtensionUninstallDialog::Create(
      GetProfile(),
      controller ? controller->window()->GetNativeWindow() : NULL,
      this);

[sashab, 2014/07/24 08:02:14]

Nice! Done.

kalman: Is this the crash you were talking about before?

+          this));
       if (extension_id() != target_extension_id) {
         extension_uninstall_dialog_->ConfirmProgrammaticUninstall(
             target_extension, GetExtension());