chrome/browser/extensions/api/management/management_api.cc - Issue 382133003: Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 382133003: Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Changed ExtensionUninstallDialog to take a NativeWindow instead of a Browser Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_context_menu_model.cc » ('j') | chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_api.cc

diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc

index 98a48995504b2bf4f6ccdcf145b8c902abad88f9..32c13f39385592edcda233cd0b8ad3c6276baed3 100644

--- a/chrome/browser/extensions/api/management/management_api.cc

+++ b/chrome/browser/extensions/api/management/management_api.cc

@@ -611,7 +611,9 @@ bool ManagementUninstallFunctionBase::Uninstall(

if (show_confirm_dialog) {

AddRef(); // Balanced in ExtensionUninstallAccepted/Canceled

extension_uninstall_dialog_.reset(ExtensionUninstallDialog::Create(

- GetProfile(), GetCurrentBrowser(), this));

+ GetProfile(),

+ chrome::FindWindowForBrowser(GetCurrentBrowser()),

+ this));

if (extension_id() != target_extension_id) {

extension_uninstall_dialog_->ConfirmProgrammaticUninstall(

target_extension, GetExtension());