Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser

chrome/browser/extensions/extension_uninstall_dialog.h

Index: chrome/browser/extensions/extension_uninstall_dialog.h
diff --git a/chrome/browser/extensions/extension_uninstall_dialog.h b/chrome/browser/extensions/extension_uninstall_dialog.h
index 0d2f112a1ad781feb8fb145e165efd98af28205a..6be94ce89b7250a5979aaa9e2d14b5636495cc6a 100644
--- a/chrome/browser/extensions/extension_uninstall_dialog.h
+++ b/chrome/browser/extensions/extension_uninstall_dialog.h
@@ -12,6 +12,7 @@
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "ui/gfx/image/image_skia.h"
+#include "ui/gfx/native_widget_types.h"
 
 class Browser;
 class Profile;
@@ -43,14 +44,19 @@ class ExtensionUninstallDialog
     virtual ~Delegate() {}
   };
 
-  // Creates a platform specific implementation of ExtensionUninstallDialog.
-  // |profile| and |delegate| can never be NULL.
-  // |browser| can be NULL only for Ash when this is used with the applist
-  // window.
+  // Creates a platform-specific implementation of ExtensionUninstallDialog for
+  // the given browser window.
   static ExtensionUninstallDialog* Create(Profile* profile,
                                           Browser* browser,
                                           Delegate* delegate);
 
+  // Create an platform-specific implementation of ExtensionUninstallDialog for
+  // a non-browser window, such as the app list.
+  static ExtensionUninstallDialog* CreateForNonBrowserWindow(

[tapted, 2014/07/11 04:39:15]

I'd probably still call it CreateForAppList - it's still design for this (just
with the parent sometimes the root app list window, and sometimes a child
widget, but that's about to change when the info dialog becomes a subview rather
than a widget.

I would still pass in |parent| - it allows the GetActiveDesktop thing to go
away.

[sashab, 2014/07/11 05:58:57]

Done.

+      Profile* profile,
+      gfx::NativeWindow parent,
+      Delegate* delegate);
+
   virtual ~ExtensionUninstallDialog();
 
   // This is called to verify whether the uninstallation should proceed.