Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm

Issue 382133003: Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review feedback & todos for unfixed issues Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_uninstall_dialog.h" 5 #include "chrome/browser/extensions/extension_uninstall_dialog.h"
6 6
7 #import <Cocoa/Cocoa.h> 7 #import <Cocoa/Cocoa.h>
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "base/strings/sys_string_conversions.h" 11 #include "base/strings/sys_string_conversions.h"
12 #include "base/strings/utf_string_conversions.h" 12 #include "base/strings/utf_string_conversions.h"
13 #include "extensions/common/extension.h" 13 #include "extensions/common/extension.h"
14 #include "grit/chromium_strings.h" 14 #include "grit/chromium_strings.h"
15 #include "grit/generated_resources.h" 15 #include "grit/generated_resources.h"
16 #include "skia/ext/skia_utils_mac.h" 16 #include "skia/ext/skia_utils_mac.h"
17 #include "ui/base/l10n/l10n_util_mac.h" 17 #include "ui/base/l10n/l10n_util_mac.h"
18 #include "ui/base/resource/resource_bundle.h" 18 #include "ui/base/resource/resource_bundle.h"
19 #include "ui/gfx/image/image_skia_util_mac.h" 19 #include "ui/gfx/image/image_skia_util_mac.h"
20 20
21 namespace { 21 namespace {
22 22
23 // The Cocoa implementation of ExtensionUninstallDialog. This has a less 23 // The Cocoa implementation of ExtensionUninstallDialog. This has a less
24 // complex life cycle than the Views and GTK implementations because the 24 // complex life cycle than the Views and GTK implementations because the
25 // dialog blocks the page from navigating away and destroying the dialog, 25 // dialog blocks the page from navigating away and destroying the dialog,
26 // so there's no way for the dialog to outlive its delegate. 26 // so there's no way for the dialog to outlive its delegate.
27 class ExtensionUninstallDialogCocoa 27 class ExtensionUninstallDialogCocoa
28 : public extensions::ExtensionUninstallDialog { 28 : public extensions::ExtensionUninstallDialog {
29 public: 29 public:
30 ExtensionUninstallDialogCocoa( 30 ExtensionUninstallDialogCocoa(Profile* profile,
31 Profile* profile, 31 gfx::NativeWindow parent,
32 Browser* browser, 32 Delegate* delegate);
33 Delegate* delegate);
34 virtual ~ExtensionUninstallDialogCocoa() OVERRIDE; 33 virtual ~ExtensionUninstallDialogCocoa() OVERRIDE;
35 34
36 private: 35 private:
37 virtual void Show() OVERRIDE; 36 virtual void Show() OVERRIDE;
38 }; 37 };
39 38
40 ExtensionUninstallDialogCocoa::ExtensionUninstallDialogCocoa( 39 ExtensionUninstallDialogCocoa::ExtensionUninstallDialogCocoa(
41 Profile* profile, 40 Profile* profile,
42 Browser* browser, 41 gfx::NativeWindow parent,
43 extensions::ExtensionUninstallDialog::Delegate* delegate) 42 extensions::ExtensionUninstallDialog::Delegate* delegate)
44 : extensions::ExtensionUninstallDialog(profile, browser, delegate) { 43 : extensions::ExtensionUninstallDialog(profile, parent, delegate) {
45 } 44 }
46 45
47 ExtensionUninstallDialogCocoa::~ExtensionUninstallDialogCocoa() {} 46 ExtensionUninstallDialogCocoa::~ExtensionUninstallDialogCocoa() {}
48 47
49 void ExtensionUninstallDialogCocoa::Show() { 48 void ExtensionUninstallDialogCocoa::Show() {
50 NSAlert* alert = [[[NSAlert alloc] init] autorelease]; 49 NSAlert* alert = [[[NSAlert alloc] init] autorelease];
51 50
52 NSButton* continueButton = [alert addButtonWithTitle:l10n_util::GetNSString( 51 NSButton* continueButton = [alert addButtonWithTitle:l10n_util::GetNSString(
53 IDS_EXTENSION_PROMPT_UNINSTALL_BUTTON)]; 52 IDS_EXTENSION_PROMPT_UNINSTALL_BUTTON)];
54 NSButton* cancelButton = [alert addButtonWithTitle:l10n_util::GetNSString( 53 NSButton* cancelButton = [alert addButtonWithTitle:l10n_util::GetNSString(
(...skipping 12 matching lines...) Expand all
67 delegate_->ExtensionUninstallAccepted(); 66 delegate_->ExtensionUninstallAccepted();
68 else 67 else
69 delegate_->ExtensionUninstallCanceled(); 68 delegate_->ExtensionUninstallCanceled();
70 } 69 }
71 70
72 } // namespace 71 } // namespace
73 72
74 // static 73 // static
75 extensions::ExtensionUninstallDialog* 74 extensions::ExtensionUninstallDialog*
76 extensions::ExtensionUninstallDialog::Create(Profile* profile, 75 extensions::ExtensionUninstallDialog::Create(Profile* profile,
77 Browser* browser, 76 gfx::NativeWindow parent,
78 Delegate* delegate) { 77 Delegate* delegate) {
79 return new ExtensionUninstallDialogCocoa(profile, browser, delegate); 78 return new ExtensionUninstallDialogCocoa(profile, parent, delegate);
80 } 79 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698