Issue 382133002: Fix use-after-free of ChildSharedBitmapManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 382133002: Fix use-after-free of ChildSharedBitmapManager (Closed)

Created:
6 years, 5 months ago by jbauman

Modified:
6 years, 5 months ago

Reviewers:
piman

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix use-after-free of ChildSharedBitmapManager Callbacks can cause the ChildSharedBitmapManager to be used after the compositor is gone, so pass the ThreadSafeSender (which is refcounted) to the callbacks instead. BUG=390563 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282729

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -26 lines)			Patch
	M	content/child/child_shared_bitmap_manager.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	content/child/child_shared_bitmap_manager.cc	View		3 chunks	+22 lines, -23 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/382133002/1

6 years, 5 months ago (2014-07-11 22:22:43 UTC) #4

Message was sent while issue was closed.

Change committed as 282729

Expand Messages | Collapse Messages