Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Issue 382123003: X87: Use a register spec for StoreIC and KeyedStoreIC. (Closed)

Created:
6 years, 5 months ago by chunyang.dai
Modified:
6 years, 5 months ago
Reviewers:
Weiliang, mvstanton
CC:
v8-dev, danno
Base URL:
https://github.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

X87: Use a register spec for StoreIC and KeyedStoreIC. port r22328 original commit message: Use a register spec for StoreIC and KeyedStoreIC. This continues refactoring already applied for LoadIC in r22035 (https://code.google.com/p/v8/source/detail?r=22035). BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -235 lines) Patch
M src/x87/code-stubs-x87.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M src/x87/debug-x87.cc View 2 chunks +9 lines, -13 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 8 chunks +20 lines, -18 lines 0 comments Download
M src/x87/ic-x87.cc View 22 chunks +147 lines, -173 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/x87/lithium-x87.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M src/x87/stub-cache-x87.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
chunyang.dai
weiliang. please review this patch. thanks.
6 years, 5 months ago (2014-07-11 05:32:35 UTC) #1
Weiliang
lgtm
6 years, 5 months ago (2014-07-11 07:30:14 UTC) #2
Weiliang
6 years, 5 months ago (2014-07-11 07:48:36 UTC) #3
Committed as r22343

Powered by Google App Engine
This is Rietveld 408576698