Issue 382113002: Only enable Hotwords when extensions are enabled.

Issue 382113002: Only enable Hotwords when extensions are enabled. (Closed)

Created:
6 years, 5 months ago by Lei Zhang

Modified:
6 years, 5 months ago

Reviewers:
rpetterson

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Only enable Hotwords when extensions are enabled. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282552

Patch Set 2 : address comments #

Patch Set 4 : rebase #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -13 lines)			Patch
M	chrome/browser/extensions/component_loader.cc	View		3 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/external_component_loader.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/resources/component_extension_resources.grd	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc	View		3 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

rpetterson

LGTM with one correction. Thanks for noticing and dealing with this! https://codereview.chromium.org/382113002/diff/20001/chrome/browser/resources/component_extension_resources.grd File chrome/browser/resources/component_extension_resources.grd (right): ...

6 years, 5 months ago (2014-07-10 23:50:03 UTC) #2

Lei Zhang

https://codereview.chromium.org/382113002/diff/20001/chrome/browser/resources/component_extension_resources.grd File chrome/browser/resources/component_extension_resources.grd (right): https://codereview.chromium.org/382113002/diff/20001/chrome/browser/resources/component_extension_resources.grd#newcode65 chrome/browser/resources/component_extension_resources.grd:65: <include name="IDR_FEEDBACK_DEFAULT_HTML" file="feedback/html/default.html" flattenhtml="true" allowexternalscript="true" type="BINDATA" /> On 2014/07/10 ...

6 years, 5 months ago (2014-07-11 00:11:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/382113002/80001

6 years, 5 months ago (2014-07-11 01:55:23 UTC) #5

Message was sent while issue was closed.

Change committed as 282552

Expand Messages | Collapse Messages