Chromium Code Reviews
Help | Chromium Project | Sign in
(42)

Issue 3821005: Make sure to use scoped_refptr for refcounted params in audio/video/remoting (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 7 months ago by willchan no longer on Chromium
Modified:
4 years ago
CC:
chromium-reviews, vrk (LEFT CHROMIUM), fbarchard, Alpha Left Google, Sergey Ulanov, ben+cc_chromium.org, dmac, darin-cc_chromium.org, garykac, brettw-cc_chromium.org, scherkus (very slow to review)
Visibility:
Public.

Description

Make sure to use scoped_refptr for refcounted params in audio/video/remoting BUG=28083 TEST=existing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62949

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -22 lines) Patch
M chrome/browser/renderer_host/audio_renderer_host.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/service/service_process.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M media/base/pipeline_impl.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M media/filters/decoder_base.h View 1 chunk +9 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M media/filters/omx_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/host_key_pair.cc View 1 chunk +3 lines, -1 line 0 comments Download
Commit: CQ not working?

Messages

Total messages: 5 (0 generated)
willchan no longer on Chromium
4 years, 7 months ago (2010-10-18 04:53:13 UTC) #1
awong (On leave)
Hey Will, I don't think I 100% understand this change. Most of our code doesn't ...
4 years, 7 months ago (2010-10-18 16:32:11 UTC) #2
scherkus (very slow to review)
Believe it's motivated by: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/9e83addf85d2b445/84cacd41c97e8814?lnk=gst
4 years, 7 months ago (2010-10-18 16:35:05 UTC) #3
willchan no longer on Chromium
Nope, it's motivated by wanting to land http://codereview.chromium.org/3549010/show to fix http://code.google.com/p/chromium/issues/detail?id=28083. On Mon, Oct 18, ...
4 years, 7 months ago (2010-10-18 17:19:27 UTC) #4
awong (On leave)
4 years, 7 months ago (2010-10-18 17:50:43 UTC) #5
LGTM

Chatted offline.  In this case, we're going to cost an unnecessary ref/deref,
but it's worth it to unblock checking in Will's CL.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be