Issue 382093002: WebTestProxy should explode if readback requests are unhandled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 382093002: WebTestProxy should explode if readback requests are unhandled (Closed)

Created:
6 years, 5 months ago by enne (OOO)

Modified:
6 years, 5 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, danakj

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

WebTestProxy should explode if readback requests are unhandled Async readback requests are a potential use-after-free if the WebTestProxy goes away before they are serviced. However, this is not actually anything a valid test would want to do if it wanted to not be racy. So, just CHECK for outstanding tasks on destruction rather than posting with a weak pointer and silently failing such readbacks. BUG=389569 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282581