Redo "Information about which functions require other functions is gathered in the enqueuer."

Redo "Information about which functions require other functions is gathered in the enqueuer."

BUG=
R=sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38175

[sra1, 2014-07-11 22:03:51]

lgtm

[Ty Overby (Google), 2014-07-11 22:18:57]

Committed patchset #4 manually as r38175 (presubmit successful).

[ahe, 2014-08-18 15:31:14]

This CL changes code that was originally written by sigurdm@, but he wasn't
CC'ed on the code review.

Please try to identify the "owners" of the code you're changing, they often
contribute with valuable information during code review, and may help catch
mistakes early. Communication between teams in different timezones can be hard,
and code reviews is one of the most powerful techniques we have to ensure we
talk :-)

Don't worry about "spamming" people. It is better to err on the side of CC'ing
too many.

https://codereview.chromium.org/382063002/diff/60001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/dump_info.dart (right):

https://codereview.chromium.org/382063002/diff/60001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/dump_info.dart:107: this.compiler =
compiler;
Please use Dart constructor syntax. For example:

ElementToJsonVisitor(Compiler compiler)
    : compiler = compiler,
      compilationInfo = compiler.enqueuer.codegen.compilationInfo,
...

Generally, try to avoid computations in constructors. It creates unreadable
code.

https://codereview.chromium.org/382063002/diff/60001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/dump_info.dart:119: dumpInfoDuration =
new DateTime.now().difference(compilationMoment);
We have CompilerTask to measure timing.

[sigurdm, 2014-08-19 06:51:15]

https://codereview.chromium.org/382063002/diff/60001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/382063002/diff/60001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:947: void
enableNoSuchMethod(context, Enqueuer world) {
DBC: Missing a type

[Ty Overby (Google), 2014-08-19 19:44:13]

Cleanup of this CL is located here: 

https://codereview.chromium.org/486313003/

https://codereview.chromium.org/382063002/diff/60001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/dump_info.dart (right):

https://codereview.chromium.org/382063002/diff/60001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/dump_info.dart:107: this.compiler =
compiler;
On 2014/08/18 15:31:14, ahe wrote:
> Please use Dart constructor syntax. For example:
> 
> ElementToJsonVisitor(Compiler compiler)
>     : compiler = compiler,
>       compilationInfo = compiler.enqueuer.codegen.compilationInfo,
> ...
> 
> Generally, try to avoid computations in constructors. It creates unreadable
> code.

Done.

https://codereview.chromium.org/382063002/diff/60001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/dump_info.dart:119: dumpInfoDuration =
new DateTime.now().difference(compilationMoment);
On 2014/08/18 15:31:14, ahe wrote:
> We have CompilerTask to measure timing.

I can't seem to find out how to extract time measurements from
CompilerTask.measure.  I could refactor this to use Stopwatch similar to
Compiler with totalCompileTime.

https://codereview.chromium.org/382063002/diff/60001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/382063002/diff/60001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:947: void
enableNoSuchMethod(context, Enqueuer world) {
On 2014/08/19 06:51:15, sigurdm wrote:
> DBC: Missing a type

Done.

[ahe, 2014-08-20 08:33:19]

https://codereview.chromium.org/382063002/diff/60001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/dump_info.dart (right):

https://codereview.chromium.org/382063002/diff/60001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/dump_info.dart:119: dumpInfoDuration =
new DateTime.now().difference(compilationMoment);
On 2014/08/19 19:44:13, Ty Overby (Google) wrote:
> On 2014/08/18 15:31:14, ahe wrote:
> > We have CompilerTask to measure timing.
> 
> I can't seem to find out how to extract time measurements from
> CompilerTask.measure.  I could refactor this to use Stopwatch similar to
> Compiler with totalCompileTime.

Create a subclass of CompilerTask and add it to compiler.tasks. Then wrap the
code you need to measure in task.measure.

[Ty Overby (Google), 2014-08-20 17:29:37]

On 2014/08/20 08:33:19, ahe wrote:
>
https://codereview.chromium.org/382063002/diff/60001/sdk/lib/_internal/compil...
> File sdk/lib/_internal/compiler/implementation/dump_info.dart (right):
> 
>
https://codereview.chromium.org/382063002/diff/60001/sdk/lib/_internal/compil...
> sdk/lib/_internal/compiler/implementation/dump_info.dart:119: dumpInfoDuration
=
> new DateTime.now().difference(compilationMoment);
> On 2014/08/19 19:44:13, Ty Overby (Google) wrote:
> > On 2014/08/18 15:31:14, ahe wrote:
> > > We have CompilerTask to measure timing.
> > 
> > I can't seem to find out how to extract time measurements from
> > CompilerTask.measure.  I could refactor this to use Stopwatch similar to
> > Compiler with totalCompileTime.
> 
> Create a subclass of CompilerTask and add it to compiler.tasks. Then wrap the
> code you need to measure in task.measure.

I do have a DumpInfoTask that is a subclass of CompilerTask.  My issue is that
if I 
want my program to output how long it took to run the DumpInfoTask, I don't know
how 
to get that info.

[sra1, 2014-08-20 18:18:32]

On 2014/08/20 17:29:37, Ty Overby (Google) wrote:
> On 2014/08/20 08:33:19, ahe wrote:
> >
>
https://codereview.chromium.org/382063002/diff/60001/sdk/lib/_internal/compil...
> > File sdk/lib/_internal/compiler/implementation/dump_info.dart (right):
> > 
> >
>
https://codereview.chromium.org/382063002/diff/60001/sdk/lib/_internal/compil...
> > sdk/lib/_internal/compiler/implementation/dump_info.dart:119:
dumpInfoDuration
> =
> > new DateTime.now().difference(compilationMoment);
> > On 2014/08/19 19:44:13, Ty Overby (Google) wrote:
> > > On 2014/08/18 15:31:14, ahe wrote:
> > > > We have CompilerTask to measure timing.
> > > 
> > > I can't seem to find out how to extract time measurements from
> > > CompilerTask.measure.  I could refactor this to use Stopwatch similar to
> > > Compiler with totalCompileTime.
> > 
> > Create a subclass of CompilerTask and add it to compiler.tasks. Then wrap
the
> > code you need to measure in task.measure.
> 
> I do have a DumpInfoTask that is a subclass of CompilerTask.  My issue is that
> if I 
> want my program to output how long it took to run the DumpInfoTask, I don't
know
> how 
> to get that info.

Looking at CompilerTask, I see a getter called 'timing'.