Update find_name_and_attributes to take ttc index.

Update find_name_and_attributes to take ttc index and rename to SkTypeface_FreeType::ScanFont.

The name 'ScanFont' is to mirror the naming convention of similar functions in FontConfig.

Committed: https://skia.googlesource.com/skia/+/3a21d61668e0ac6529f9930669dd47be123ec333

[tomhudson, 2014-07-11 13:30:21]

https://codereview.chromium.org/382053003/diff/1/src/ports/SkFontHost_FreeTyp...
File src/ports/SkFontHost_FreeType.cpp (right):

https://codereview.chromium.org/382053003/diff/1/src/ports/SkFontHost_FreeTyp...
src/ports/SkFontHost_FreeType.cpp:1676: bool find_name_and_attributes(SkStream*
stream, int ttcIndex,
If we're exporting this, shouldn't it have an SkCamelCaps name, and consider
belonging to a namespace?

[bungeman-skia, 2014-07-11 14:33:26]

https://codereview.chromium.org/382053003/diff/1/src/ports/SkFontHost_FreeTyp...
File src/ports/SkFontHost_FreeType.cpp (right):

https://codereview.chromium.org/382053003/diff/1/src/ports/SkFontHost_FreeTyp...
src/ports/SkFontHost_FreeType.cpp:1676: bool find_name_and_attributes(SkStream*
stream, int ttcIndex,
On 2014/07/11 13:30:21, tomhudson wrote:
> If we're exporting this, shouldn't it have an SkCamelCaps name, and consider
> belonging to a namespace?

Sure, why not. It wasn't static to begin with, so it doesn't make much sense to
use the current naming convention. Always difficult to tell how far to take
these sort of refactors.

[tomhudson, 2014-07-11 14:46:22]

lgtm

[bungeman-skia, 2014-07-11 14:52:37]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2014-07-11 14:53:17]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bungeman@google.com/382053003/20001

[commit-bot: I haz the power, 2014-07-11 15:52:32]

Change committed as 3a21d61668e0ac6529f9930669dd47be123ec333