Issue 382053002: Revert of Enable tools/CrashHandler again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 382053002: Revert of Enable tools/CrashHandler again. (Closed)

Created:
6 years, 5 months ago by reed1

Modified:
6 years, 5 months ago

Reviewers:
borenet, mtklein, mtklein_C

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Enable tools/CrashHandler again. (https://codereview.chromium.org/383813002/) Reason for revert: broke mac 10.6 Original issue's description: > Enable tools/CrashHandler again. > > - Defaults to on the bots, triggered off CHROME_HEADLESS=1 in the environment. > - Defaults off otherwise. > - Can be enabled by setting CHROME_HEADLESS=1 (weird) or GYP_DEFINES=skia_crash_handler=1. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4d1605a8d64792c03e3a93178d51ad6d23fc5ea6 TBR=borenet@google.com,mtklein@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:

Created: 6 years, 5 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	gyp/common_conditions.gypi	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	gyp/common_variables.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

The CQ bit was unchecked by reed@google.com