Issue 382043003: Add ExternalTimerEventScope to log non internal timer events scopes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 382043003: Add ExternalTimerEventScope to log non internal timer events scopes (Closed)

Created:
6 years, 5 months ago by fmeawad

Modified:
5 years, 6 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Add ExternalTimerEventScope to log non internal timer events scopes BUG=3432 LOG=N

Patch Set 1 #

Patch Set 2 : Minor fix #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -17 lines)			Patch
M	src/ic.cc	View		17 chunks	+17 lines, -17 lines	0 comments	Download
M	src/log.h	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
M	src/log.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

fmeawad

After the addition of the IcMiss timer events, the buffers gets filed rather quickly, and ...

6 years, 5 months ago (2014-07-10 21:35:01 UTC) #1

Yang

6 years, 5 months ago (2014-07-11 07:11:27 UTC) #2

On 2014/07/10 21:35:01, fmeawad-cr wrote:
> After the addition of the IcMiss timer events, the buffers gets filed rather
> quickly, and the logs becomes un-proccessable for many websites and
benchmarks.
> 
> Attempting to allow to log but exclude the IcMisses, feel free to suggest a
> different approach.

There is nothing external to IC misses. Let me come up with a CL.

Expand Messages | Collapse Messages