Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 382023002: Changes Windows removable drive listing to include all USB drives. (Closed)

Created:
6 years, 5 months ago by Drew Haven
Modified:
6 years, 5 months ago
Reviewers:
tbarzic
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Some drives do not report themselves as removable despite appearing to a user to be a removable drive. Particularly this is the case for some USB sticks. We are fixing this by changing the device listing to list all drives that are either removable or attached via USB. We have already done a similar change for Chrome OS due to some SD card readers listing themselves as non-removable. Chrome OS lists all SD or USB drives. However, we do not have a reliable way to detect SD cards on Windows and Mac so we will continue to use the removable flag. BUG=392943 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282528

Patch Set 1 #

Patch Set 2 : Cleanup of unnecessary changes. #

Patch Set 3 : Cleans up some more unnecessary changes, no really, and uses an enum instead of int for the USB Bus… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/extensions/api/image_writer_private/removable_storage_provider_win.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/utility/image_writer/image_writer_win.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Drew Haven
Here's a companion CL to the Linux one I sent you earlier this week. This ...
6 years, 5 months ago (2014-07-10 21:08:28 UTC) #1
tbarzic
lgtm
6 years, 5 months ago (2014-07-10 21:14:54 UTC) #2
Drew Haven
The CQ bit was checked by haven@chromium.org
6 years, 5 months ago (2014-07-10 22:13:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haven@chromium.org/382023002/30001
6 years, 5 months ago (2014-07-10 22:15:50 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win8_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-11 02:57:28 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 03:35:47 UTC) #6
Message was sent while issue was closed.
Change committed as 282528

Powered by Google App Engine
This is Rietveld 408576698