Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: ui/message_center/views/notification_view.cc

Issue 381953002: New avatar button: Consolidate text elision between Mac and Win/Linux (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use TruncateString Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/message_center/views/notification_view.cc
diff --git a/ui/message_center/views/notification_view.cc b/ui/message_center/views/notification_view.cc
index be77657f6e0dc522854ebeffeaff888419488b41..32c794b1df786581ab456a3c4e25cd4bb195897e 100644
--- a/ui/message_center/views/notification_view.cc
+++ b/ui/message_center/views/notification_view.cc
@@ -532,7 +532,7 @@ void NotificationView::CreateOrUpdateTitleView(
int padding = kTitleLineHeight - font_list.GetHeight();
title_view_ = new BoundedLabel(
- gfx::TruncateString(notification.title(), title_character_limit),
+ gfx::TruncateString(notification.title(), title_character_limit, true),
font_list);
title_view_->SetLineHeight(kTitleLineHeight);
title_view_->SetLineLimit(kMaxTitleLines);
@@ -542,7 +542,7 @@ void NotificationView::CreateOrUpdateTitleView(
top_view_->AddChildView(title_view_);
} else {
title_view_->SetText(
- gfx::TruncateString(notification.title(), title_character_limit));
+ gfx::TruncateString(notification.title(), title_character_limit, true));
}
}
@@ -561,16 +561,18 @@ void NotificationView::CreateOrUpdateMessageView(
if (!message_view_) {
int padding = kMessageLineHeight - views::Label().font_list().GetHeight();
- message_view_ = new BoundedLabel(
- gfx::TruncateString(notification.message(), kMessageCharacterLimit));
+ message_view_ = new BoundedLabel(gfx::TruncateString(notification.message(),
+ kMessageCharacterLimit,
+ true));
message_view_->SetLineHeight(kMessageLineHeight);
message_view_->SetColors(message_center::kRegularTextColor,
kDimTextBackgroundColor);
message_view_->SetBorder(MakeTextBorder(padding, 4, 0));
top_view_->AddChildView(message_view_);
} else {
- message_view_->SetText(
- gfx::TruncateString(notification.message(), kMessageCharacterLimit));
+ message_view_->SetText(gfx::TruncateString(notification.message(),
+ kMessageCharacterLimit,
+ true));
}
message_view_->SetVisible(!notification.items().size());
@@ -592,7 +594,7 @@ void NotificationView::CreateOrUpdateContextMessageView(
if (!context_message_view_) {
int padding = kMessageLineHeight - views::Label().font_list().GetHeight();
context_message_view_ = new BoundedLabel(gfx::TruncateString(
- notification.context_message(), kContextMessageCharacterLimit));
+ notification.context_message(), kContextMessageCharacterLimit, true));
context_message_view_->SetLineLimit(
message_center::kContextMessageLineLimit);
context_message_view_->SetLineHeight(kMessageLineHeight);
@@ -602,7 +604,7 @@ void NotificationView::CreateOrUpdateContextMessageView(
top_view_->AddChildView(context_message_view_);
} else {
context_message_view_->SetText(gfx::TruncateString(
- notification.context_message(), kContextMessageCharacterLimit));
+ notification.context_message(), kContextMessageCharacterLimit, true));
}
}

Powered by Google App Engine
This is Rietveld 408576698