New avatar button: Consolidate text elision between Mac and Win/Linux

ui/message_center/views/notification_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/message_center/views/notification_view.h"
 
 #include "base/command_line.h"
 #include "base/stl_util.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 514 matching lines @@
   const gfx::FontList& font_list =
       views::Label().font_list().DeriveWithSizeDelta(2);
 
   int title_character_limit =
       kNotificationWidth * kMaxTitleLines / kMinPixelsPerTitleCharacter;
 
   if (!title_view_) {
     int padding = kTitleLineHeight - font_list.GetHeight();
 
     title_view_ = new BoundedLabel(
-        gfx::TruncateString(notification.title(), title_character_limit),
+        gfx::TruncateString(notification.title(),

[msw, 2014/07/21 15:26:07]

nit: init a shared local |title| string outside the if/else block.

[Marc Treib, 2014/07/21 16:43:52]

Done.

+                            title_character_limit,
+                            gfx::WORD_BREAK),
         font_list);
     title_view_->SetLineHeight(kTitleLineHeight);
     title_view_->SetLineLimit(kMaxTitleLines);
     title_view_->SetColors(message_center::kRegularTextColor,
                            kRegularTextBackgroundColor);
     title_view_->SetBorder(MakeTextBorder(padding, 3, 0));
     top_view_->AddChildView(title_view_);
   } else {
     title_view_->SetText(
-        gfx::TruncateString(notification.title(), title_character_limit));
+        gfx::TruncateString(notification.title(),
+                            title_character_limit,
+                            gfx::WORD_BREAK));
   }
 }
 
 void NotificationView::CreateOrUpdateMessageView(
     const Notification& notification) {
   if (notification.message().empty()) {
     if (message_view_) {
       // Deletion will also remove |message_view_| from its parent.
       delete message_view_;
       message_view_ = NULL;
     }
     return;
   }
 
   DCHECK(top_view_ != NULL);
 
   if (!message_view_) {
     int padding = kMessageLineHeight - views::Label().font_list().GetHeight();
-    message_view_ = new BoundedLabel(
-        gfx::TruncateString(notification.message(), kMessageCharacterLimit));
+    message_view_ = new BoundedLabel(gfx::TruncateString(notification.message(),

[msw, 2014/07/21 15:26:07]

ditto

[Marc Treib, 2014/07/21 16:43:52]

Done.

+                                                         kMessageCharacterLimit,
+                                                         gfx::WORD_BREAK));
     message_view_->SetLineHeight(kMessageLineHeight);
     message_view_->SetColors(message_center::kRegularTextColor,
                              kDimTextBackgroundColor);
     message_view_->SetBorder(MakeTextBorder(padding, 4, 0));
     top_view_->AddChildView(message_view_);
   } else {
-    message_view_->SetText(
-        gfx::TruncateString(notification.message(), kMessageCharacterLimit));
+    message_view_->SetText(gfx::TruncateString(notification.message(),
+                                               kMessageCharacterLimit,
+                                               gfx::WORD_BREAK));
   }
 
   message_view_->SetVisible(!notification.items().size());
 }
 
 void NotificationView::CreateOrUpdateContextMessageView(
     const Notification& notification) {
   if (notification.context_message().empty()) {
     if (context_message_view_) {
       // Deletion will also remove |context_message_view_| from its parent.
       delete context_message_view_;
       context_message_view_ = NULL;
     }
     return;
   }
 
   DCHECK(top_view_ != NULL);
 
   if (!context_message_view_) {
     int padding = kMessageLineHeight - views::Label().font_list().GetHeight();
-    context_message_view_ = new BoundedLabel(gfx::TruncateString(
-        notification.context_message(), kContextMessageCharacterLimit));
+    context_message_view_ =
+        new BoundedLabel(gfx::TruncateString(notification.context_message(),

[msw, 2014/07/21 15:26:07]

ditto

[Marc Treib, 2014/07/21 16:43:52]

Done.

+                                             kContextMessageCharacterLimit,
+                                             gfx::WORD_BREAK));
     context_message_view_->SetLineLimit(
         message_center::kContextMessageLineLimit);
     context_message_view_->SetLineHeight(kMessageLineHeight);
     context_message_view_->SetColors(message_center::kDimTextColor,
                                      kContextTextBackgroundColor);
     context_message_view_->SetBorder(MakeTextBorder(padding, 4, 0));
     top_view_->AddChildView(context_message_view_);
   } else {
-    context_message_view_->SetText(gfx::TruncateString(
-        notification.context_message(), kContextMessageCharacterLimit));
+    context_message_view_->SetText(
+        gfx::TruncateString(notification.context_message(),
+                            kContextMessageCharacterLimit,
+                            gfx::WORD_BREAK));
   }
 }
 
 void NotificationView::CreateOrUpdateProgressBarView(
     const Notification& notification) {
   if (notification.type() != NOTIFICATION_TYPE_PROGRESS) {
     if (progress_bar_view_) {
       // Deletion will also remove |progress_bar_view_| from its parent.
       delete progress_bar_view_;
       progress_bar_view_ = NULL;
@@ skipping 162 matching lines @@
 
   return message_line_limit;
 }
 
 int NotificationView::GetMessageHeight(int width, int limit) const {
   return message_view_ ?
          message_view_->GetSizeForWidthAndLines(width, limit).height() : 0;
 }
 
 }  // namespace message_center