Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 381933002: import google-api-python-client using DEPS (Closed)

Created:
6 years, 5 months ago by epoger
Modified:
6 years, 5 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org, borenet, rmistry
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

import google-api-python-client using DEPS BUG=skia:2641 Committed: https://skia.googlesource.com/skia/+/fd429991e99d18cbb956f91b7c347440b39684c1

Patch Set 1 #

Total comments: 1

Patch Set 2 : added httplib2 and uritemplate to DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M DEPS View 1 1 chunk +8 lines, -0 lines 0 comments Download
M tools/pyutils/gs_utils.py View 1 1 chunk +21 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
epoger
Joe- please review at patchset 1.
6 years, 5 months ago (2014-07-10 15:24:12 UTC) #1
epoger
P.S. I suspect this will still fail on some machines, needing a "uritemplate" dependency. Committing ...
6 years, 5 months ago (2014-07-10 15:26:16 UTC) #2
jcgregorio
https://codereview.chromium.org/381933002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/381933002/diff/1/DEPS#newcode25 DEPS:25: "third_party/externals/oauth2client" : "https://github.com/google/oauth2client.git@d02b317af0313dcf66755844f5421651af5eb356", Do you also need? pyasn1 pyasn1_modules ...
6 years, 5 months ago (2014-07-10 15:31:40 UTC) #3
epoger
On 2014/07/10 15:31:40, jcgregorio wrote: > https://codereview.chromium.org/381933002/diff/1/DEPS > File DEPS (right): > > https://codereview.chromium.org/381933002/diff/1/DEPS#newcode25 > ...
6 years, 5 months ago (2014-07-10 15:42:33 UTC) #4
jcgregorio
On 2014/07/10 15:42:33, epoger wrote: > On 2014/07/10 15:31:40, jcgregorio wrote: > > https://codereview.chromium.org/381933002/diff/1/DEPS > ...
6 years, 5 months ago (2014-07-10 15:43:11 UTC) #5
epoger
The CQ bit was checked by epoger@google.com
6 years, 5 months ago (2014-07-10 15:45:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/381933002/20001
6 years, 5 months ago (2014-07-10 15:47:20 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 16:03:33 UTC) #8
Message was sent while issue was closed.
Change committed as fd429991e99d18cbb956f91b7c347440b39684c1

Powered by Google App Engine
This is Rietveld 408576698