Issue 381913003: [Resources] Add a <meta> tag to promo.html have better layout on mobile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 381913003: [Resources] Add a <meta> tag to promo.html have better layout on mobile. (Closed)

Created:
6 years, 5 months ago by Mathieu

Modified:
6 years, 5 months ago

Reviewers:
huangs

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Resources] Add a <meta> tag to promo.html have better layout on mobile. Adding this meta tag allows the page to have proper scaling. BUG=None TEST=Manual R=huangs@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282353

Patch Set 1 #

Total comments: 2

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/resources/contextual_search/promo.html	View		1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

huangs

lgtm https://codereview.chromium.org/381913003/diff/1/chrome/browser/resources/contextual_search/promo.html File chrome/browser/resources/contextual_search/promo.html (right): https://codereview.chromium.org/381913003/diff/1/chrome/browser/resources/contextual_search/promo.html#newcode10 chrome/browser/resources/contextual_search/promo.html:10: <meta name="viewport" content="width=device-width, user-scalable=no"> Do you also want ...

6 years, 5 months ago (2014-07-10 14:22:31 UTC) #1

Mathieu

Committed patchset #1 manually as r282353 (presubmit successful).

6 years, 5 months ago (2014-07-10 16:37:29 UTC) #2

Mathieu

6 years, 5 months ago (2014-07-14 16:22:49 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/381913003/diff/1/chrome/browser/resources/con...
File chrome/browser/resources/contextual_search/promo.html (right):

https://codereview.chromium.org/381913003/diff/1/chrome/browser/resources/con...
chrome/browser/resources/contextual_search/promo.html:10: <meta name="viewport"
content="width=device-width, user-scalable=no">
On 2014/07/10 14:22:31, huangs1 wrote:
> Do you also want initial-scale=1.0 ?

No.

Expand Messages | Collapse Messages