Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Unified Diff: media/BUILD.gn

Issue 381903003: Enable media in default GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove duplicate media.cc Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/BUILD.gn
diff --git a/media/BUILD.gn b/media/BUILD.gn
index ce95d1fad9982812f824b72bff95f93541167d3e..2d606e284d178015c592df07f8bea578529875ec 100644
--- a/media/BUILD.gn
+++ b/media/BUILD.gn
@@ -31,7 +31,7 @@ if (is_android) {
# Original conditional: (OS=="linux" or OS=="freebsd" or OS=="solaris") and embedded!=1
use_alsa = false
use_pulseaudio = false
-if (is_posix) {
+if (is_posix && !is_android) {
use_alsa = true
if (!use_cras) {
use_pulseaudio = true
@@ -595,8 +595,6 @@ component("media") {
"base/android/media_player_manager.h",
"base/android/media_resource_getter.cc",
"base/android/media_resource_getter.h",
- "base/media.cc",
- "base/media.h",
"base/media_stub.cc",
"midi/midi_manager_android.cc",
"midi/usb_midi_device_android.cc",
@@ -622,7 +620,7 @@ component("media") {
if (is_chromeos) {
# A simple WebM encoder for animated avatars on ChromeOS.
- sources += [
+ sources += [
"formats/webm/chromeos/ebml_writer.cc",
"formats/webm/chromeos/ebml_writer.h",
"formats/webm/chromeos/webm_encoder.cc",
@@ -1288,48 +1286,50 @@ component("shared_memory_support") {
deps = [ "//base" ]
}
-test("ffmpeg_unittests") {
- sources = [ "ffmpeg/ffmpeg_unittest.cc" ]
+if (media_use_ffmpeg) {
+ test("ffmpeg_unittests") {
+ sources = [ "ffmpeg/ffmpeg_unittest.cc" ]
- deps = [
- ":media",
- ":media_test_support",
- "//base",
- "//base:i18n",
- "//base/test:test_support",
- "//testing/gtest",
- "//third_party/ffmpeg",
- "//ui/gfx:gfx_test_support",
- ]
-}
+ deps = [
+ ":media",
+ ":media_test_support",
+ "//base",
+ "//base:i18n",
+ "//base/test:test_support",
+ "//testing/gtest",
+ "//third_party/ffmpeg",
+ "//ui/gfx:gfx_test_support",
+ ]
+ }
-test("ffmpeg_regression_tests") {
- sources = [
- "base/run_all_unittests.cc",
- "ffmpeg/ffmpeg_regression_tests.cc",
- "filters/pipeline_integration_test_base.cc",
- ]
- configs += [ ":media_config" ]
- deps = [
- ":media",
- ":media_test_support",
- "//base/test:test_support",
- "//testing/gmock",
- "//testing/gtest",
- "//third_party/ffmpeg",
- "//ui/gfx/geometry",
- "//ui/gfx:gfx_test_support",
- ]
-# TODO(ajwong): This was in the original gyp, but it seems silly.
-# ['os_posix==1 and OS!="mac"', {
-# 'conditions': [
-# ['use_allocator!="none"', {
-# 'dependencies': [
-# '../base/allocator/allocator.gyp:allocator',
-# ],
-# }],
-# ],
-# }],
+ test("ffmpeg_regression_tests") {
+ sources = [
+ "base/run_all_unittests.cc",
+ "ffmpeg/ffmpeg_regression_tests.cc",
+ "filters/pipeline_integration_test_base.cc",
+ ]
+ configs += [ ":media_config" ]
+ deps = [
+ ":media",
+ ":media_test_support",
+ "//base/test:test_support",
+ "//testing/gmock",
+ "//testing/gtest",
+ "//third_party/ffmpeg",
+ "//ui/gfx/geometry",
+ "//ui/gfx:gfx_test_support",
+ ]
+ # TODO(ajwong): This was in the original gyp, but it seems silly.
+ # ['os_posix==1 and OS!="mac"', {
+ # 'conditions': [
+ # ['use_allocator!="none"', {
+ # 'dependencies': [
+ # '../base/allocator/allocator.gyp:allocator',
+ # ],
+ # }],
+ # ],
+ # }],
+ }
}
if (use_x11) {
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698