Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5122)

Unified Diff: chrome/test/data/nacl/nacl_test_data.gyp

Issue 381883002: Non-SFI NaCl: Fix browser_tests based on libc_free.c (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: drop -O2 Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/nacl/nonsfi/libc_free.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/nacl/nacl_test_data.gyp
diff --git a/chrome/test/data/nacl/nacl_test_data.gyp b/chrome/test/data/nacl/nacl_test_data.gyp
index ea5e198cde0f3a5b8971e9d2d0648e2fef286092..71949d1d7b776405776bf44cedc1d27ce79918ca 100644
--- a/chrome/test/data/nacl/nacl_test_data.gyp
+++ b/chrome/test/data/nacl/nacl_test_data.gyp
@@ -1139,6 +1139,11 @@
# Stack-Smashing protector does not work with libc-free context.
'-fno-stack-protector',
+ # Optimizers may translate the original code to code which
hamaji 2014/07/11 07:46:16 Sorry, the previous patch was not sufficient for r
+ # requires builtin functions and/or relocations. Actually,
Mark Seaborn 2014/07/11 16:27:24 Nit: 'Actually' -> 'Specifically', perhaps?
hamaji 2014/07/11 18:34:36 Done.
+ # the LLVM's optimizer translates for-loop based zero
+ # clear to memset.
+ '-O0',
],
'cflags!': [
# We filter these out because release_extra_cflags or another
@@ -1148,10 +1153,14 @@
'-fstack-protector-all',
'-fprofile-generate',
'-finstrument-functions',
+ '-O2',
],
'ldflags': [
'-nostdlib',
'-shared',
+ # This binary cannot relocate itself, so we should have no
+ # undefined references left.
+ '-Wl,--no-undefined',
],
'ldflags!': [
# Explicitly remove the -pthread flag to avoid a link time warning.
« no previous file with comments | « no previous file | chrome/test/data/nacl/nonsfi/libc_free.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698