Issue 381873002: Implemented method for printing invalidation sets.

Issue 381873002: Implemented method for printing invalidation sets. (Closed)

Created:
6 years, 5 months ago by rune

Modified:
6 years, 5 months ago

Reviewers:
chrishtr, esprehn

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Implemented method for printing invalidation sets. Add a show method to invalidation sets like we have for selectors for use while debugging. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177970

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed review comments #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -0 lines)			Patch
	M	Source/core/css/invalidation/DescendantInvalidationSet.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	Source/core/css/invalidation/DescendantInvalidationSet.cpp	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

chrishtr

https://codereview.chromium.org/381873002/diff/1/Source/core/css/invalidation/DescendantInvalidationSet.cpp File Source/core/css/invalidation/DescendantInvalidationSet.cpp (right): https://codereview.chromium.org/381873002/diff/1/Source/core/css/invalidation/DescendantInvalidationSet.cpp#newcode199 Source/core/css/invalidation/DescendantInvalidationSet.cpp:199: printf("{ "); fprintf(stderr, ...) instead. Prefix with "DescendantInvalidationSet".

6 years, 5 months ago (2014-07-10 16:50:03 UTC) #2

rune

https://codereview.chromium.org/381873002/diff/1/Source/core/css/invalidation/DescendantInvalidationSet.cpp File Source/core/css/invalidation/DescendantInvalidationSet.cpp (right): https://codereview.chromium.org/381873002/diff/1/Source/core/css/invalidation/DescendantInvalidationSet.cpp#newcode199 Source/core/css/invalidation/DescendantInvalidationSet.cpp:199: printf("{ "); On 2014/07/10 16:50:02, chrishtr wrote: > fprintf(stderr, ...

6 years, 5 months ago (2014-07-11 09:21:27 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/381873002/20001

6 years, 5 months ago (2014-07-11 17:33:39 UTC) #5

Message was sent while issue was closed.

Change committed as 177970

Expand Messages | Collapse Messages